This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 05/19] PRU LD Port


On Mon, Dec 05, 2016 at 10:42:20PM +0200, Dimitar Dimitrov wrote:
> +  /* Internal text space.  */
> +  .text ${RELOCATING-0} :
> +  {
> +    ${RELOCATING+ __text_start = . ; }
> +
> +    ${RELOCATING+. = ALIGN(4);}
> +
> +    *(.init0)  /* Start here after reset.  */

A lot of other embedded scripts get this wrong too.  Do you really
want .init0 section to be mashed into .text for ld -r?  Ditto for
other .init*/.fini* sections, and .text.*?

> +    ${RELOCATING+ *(.data*)}
> +    *(.rodata)  /* We need to include .rodata here if gcc is used.  */
> +    ${RELOCATING+ *(.rodata*)} /* with -fdata-sections.  */
> +    *(.gnu.linkonce.d*)

Same comment applies here for these sections in .data.

> +    *(.bss)
> +    ${RELOCATING+ *(.bss*)}

Did you mean .bss.* here?  What about .gnu.linkonce.b.* since you
mention other .gnu.linkonce sections in the script?

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]