This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] readelf: use hex prefix for program header alignment

On 08 Dec 2016 20:23, Étienne Buira wrote:
> On Thu, Dec 08, 2016 at 12:09:21PM -0500, Hans-Peter Nilsson wrote:
> > Missing updates to the test-suite.  I'm guessing that's going to
> > be a big patch.
> binutils/$ make check passes both with and without the patch.
> About the whole testsuite, it is unrunable (many test failures, i
> suspect many of them to be test errors actually), so i don't know if i
> broken them more than they are.
> Fixing binutils' testsuite is not in my current plans.

we aren't expecting you to fix existing broken tests, but new patches
shouldn't cause regressions.  so usually what people will do is run
the whole testsuite (binutils, ld, gas, gold, etc...) w/their changes
and if there are any failures, they'll revert their changes and see if
the test fails in the same way.  if it does, they ignore it.  if it
doesn't, then it's their responsibility to fix the failure because it
was their new change that caused the problem.

Attachment: signature.asc
Description: Digital signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]