This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: binutils/bfd/coffcode.h: FAAL through
- From: Nick Clifton <nickc at redhat dot com>
- To: Дилян Палузов <dilyan dot palauzov at aegee dot org>, Luke Allardyce <lukeallardyce at gmail dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Mon, 14 Nov 2016 09:07:56 +0000
- Subject: Re: binutils/bfd/coffcode.h: FAAL through
- Authentication-results: sourceware.org; auth=none
- References: <F58A3288-C117-4671-B13D-BB032B685288@aegee.org> <5826417c.0901430a.7bf93.014e@mx.google.com> <68CDA6BE-CD0E-413E-A634-2B37593B8833@aegee.org> <865b40d2-2c77-cc6b-bc8f-95e8eef115ed@redhat.com> <bfc96231-c532-2679-3fd7-ad82fac2aab2@aegee.org>
Hi Dilian,
> can you also add /* Fall through */ in ld/lexsup.c:line 710?
No! :-)
But I am not being mean. The %F in call to einfo on line 709
makes the call fatal, so einfo will not return. Hence it cannot
fall through into the case statement below. I have however added
a "break;" statement instead so that anyone reading the code,
including gcc's new fall through detector, will not think that
there is an accidental cascade.
Cheers
Nick
ld/ChangeLog
2016-11-14 Nick Clifton <nickc@redhat.com>
* lexsup.c (parse_args): Add break at end of default case.