This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [AArch64] PR target/20666, fix wrong encoding of new introduced BFC pseudo
- From: "Jan Beulich" <JBeulich at suse dot com>
- To: "Jiong Wang" <jiong dot wang at foss dot arm dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Mon, 07 Nov 2016 04:55:06 -0700
- Subject: Re: [AArch64] PR target/20666, fix wrong encoding of new introduced BFC pseudo
- Authentication-results: sourceware.org; auth=none
- References: <56544752.5050609@foss.arm.com> <78e71eb3-55f8-1373-c702-c772d33d461d@foss.arm.com>
>>> On 10.10.16 at 18:40, <jiong.wang@foss.arm.com> wrote:
> On 24/11/15 11:17, Matthew Wahab wrote:
>> opcodes/
>> 2015-11-24 Matthew Wahab <matthew.wahab@arm.com>
>>
>> * aarch64-asm-2.c: Regenerate.
>> * aarch64-asm.c (convert_bfc_to_bfm): New.
>
> There looks like a copy & paste error in this function, and caused PR
> target/20666.
>
> +convert_bfc_to_bfm (aarch64_inst *inst)
> +{
> + int64_t lsb, width;
> +
> + /* Insert XZR. */
> + copy_operand_info (inst, 3, 2);
> + copy_operand_info (inst, 2, 1);
> + copy_operand_info (inst, 2, 0);
> ^~~~~~~ should be "0".
Why 0? That makes this particular copy_operand_info() invocation
a no-op afaict. Aiui you mean 1 here instead.
Jan