This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 1/2] Support GAS flag -mfloat-abi; remove .option soft/hard-float
- From: Palmer Dabbelt <palmer at dabbelt dot com>
- To: kito dot cheng at gmail dot com
- Cc: joseph at codesourcery dot com
- Cc: binutils at sourceware dot org
- Cc: Andrew Waterman <andrew at sifive dot com>
- Date: Thu, 03 Nov 2016 09:40:42 -0700 (PDT)
- Subject: Re: [PATCH 1/2] Support GAS flag -mfloat-abi; remove .option soft/hard-float
- Authentication-results: sourceware.org; auth=none
OK, if it's possible that seems better. Since you're familiar with the RISC-V
tools development process, can you submit your proposal as a patch against the
"riscv-next" branch on http://github.com/riscv/riscv-binutils-gdb ? That way
we don't blow up everyone's mailbox while trying to figure out what we're
doing.
I think we're going to try and submit a "RISC-V fixes" patchset somewhat soon
that contains a bunch of stuff to fix the RISC-V port, including a fixed
version of this patch. I think this might be easier for everyone that trying
to stage a bunch of independent patches, but if you guys think it's better to
format things differently I'll do whatever is best for everyone.
On Thu, 03 Nov 2016 09:12:27 PDT (-0700), kito.cheng@gmail.com wrote:
> Hi Palmer:
>
> I think float abi can be folding to 2 bit to represent it since ELF flags
> is very limited resource in the header, so we should use extend/change it
> carefully.
>
>
>
> On Wed, Nov 2, 2016 at 7:07 AM, Palmer Dabbelt <palmer@dabbelt.com> wrote:
>
>> On Tue, 01 Nov 2016 15:52:45 PDT (-0700), joseph@codesourcery.com wrote:
>> > On Tue, 1 Nov 2016, Palmer Dabbelt wrote:
>> >
>> >> diff --git a/gas/config/tc-riscv.c b/gas/config/tc-riscv.c
>> >> index 592c95a..b9c349e 100644
>> >> --- a/gas/config/tc-riscv.c
>> >> +++ b/gas/config/tc-riscv.c
>> >> @@ -1717,8 +1717,7 @@ enum options
>> >> OPTION_MARCH,
>> >> OPTION_PIC,
>> >> OPTION_NO_PIC,
>> >> - OPTION_MSOFT_FLOAT,
>> >> - OPTION_MHARD_FLOAT,
>> >> + OPTION_MFLOAT_ABI,
>> >> OPTION_MRVC,
>> >> OPTION_MNO_RVC,
>> >> OPTION_END_OF_ENUM
>> >> @@ -1734,20 +1733,20 @@ struct option md_longopts[] =
>> >> {"fno-pic", no_argument, NULL, OPTION_NO_PIC},
>> >> {"mrvc", no_argument, NULL, OPTION_MRVC},
>> >> {"mno-rvc", no_argument, NULL, OPTION_MNO_RVC},
>> >> - {"msoft-float", no_argument, NULL, OPTION_MSOFT_FLOAT},
>> >> - {"mhard-float", no_argument, NULL, OPTION_MHARD_FLOAT},
>> >> + {"mfloat-abi", required_argument, NULL, OPTION_MFLOAT_ABI},
>> >
>> > Whenever you add or change assembler options you need to update the
>> > manual: c-riscv.texi, and the list of options for the manpage under "@c
>> > man begin TARGET" in as.texinfo (this port appears to be missing the
>> > latter).
>>
>> Sorry about that. I can re-spin the patch so the documentation matches,
>> and
>> I've added the TARGET section as another patch.
>>