This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Ping~]Re: [2.26 backport][AArch64] PR target/20553, fix opcode mask for SIMD multiply by element


On 29/09/16 15:13, Jiong Wang wrote:
On 29/09/16 14:46, Jiong Wang wrote:


On 29/09/16 14:27, Ramana Radhakrishnan wrote:
On Thu, Sep 29, 2016 at 2:16 PM, Nick Clifton <nickc@redhat.com> wrote:
Hi Jiong,

opcode/
2016-09-27  Jiong Wang  <jiong.wang@arm.com>

* aarch64-tbl.h (fmla, fmls, fmul, fmulx): Fix opcode mask field.

gas/
2016-09-27  Jiong Wang  <jiong.wang@arm.com>

* testsuite/gas/aarch64/advsimd-fp16.s (indexed_elem): New high index testcases for H and S variants. New low index testcases for D variant. * testsuite/gas/aarch64/advsimd-fp16.d: Update expected results.
Approved - please apply.

Jiong while you are at it - What release branches should this go into?

I think it needs to be backported to 2.26 and 2.27.

Unfortunately, this patch won't apply cleanly on either. For aarch64-tbl.h, after 2.26 we introduced some wrapper macros, and after 2.27 we adjusted parameters of those macros. The change will be trivial, I will send out two backport patches shortly.

Thanks.

Here is the backport patch to 2.26, build & cross gas check OK against 2.26 branch.

OK to backport?

Hi Tristan,

Ping this patch and the 2.27 backport patch (https://sourceware.org/ml/binutils/2016-09/msg00239.html).

OK for backportting? it's disassembler bug which caused the disassembler print wrong results.

  Thanks.

Regards,
Jiong


opcode/
2016-09-29  Jiong Wang  <jiong.wang@arm.com>

        PR target/20553
        * aarch64-tbl.h (fmla, fmls, fmul, fmulx): Fix opcode mask field.

gas/
2016-09-29  Jiong Wang  <jiong.wang@arm.com>

        PR target/20553
* testsuite/gas/aarch64/advsimd-fp16.s (indexed_elem): New high index testcases for H and S variants. New low index testcases for D variant.
        * testsuite/gas/aarch64/advsimd-fp16.d: Update expected results.





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]