This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] ARM: Fix relocation of EXIDX sections

From: Andreas Schwab <schwab at suse dot de>
To: Akihiko Odaki <akihiko dot odaki dot 4i at stu dot hosei dot ac dot jp>
Cc: binutils at sourceware dot org, Paul Brook <paul at codesourcery dot com>, Yury Usishchev <y dot usishchev at samsung dot com>
Date: Tue, 13 Sep 2016 09:16:04 +0200
Subject: Re: [PATCH] ARM: Fix relocation of EXIDX sections
Authentication-results: sourceware.org; auth=none
References: <20160911093023.10112-1-akihiko.odaki.4i@stu.hosei.ac.jp> <20160913064718.12473-1-akihiko.odaki.4i@stu.hosei.ac.jp>

On Sep 13 2016, Akihiko Odaki <akihiko.odaki.4i@stu.hosei.ac.jp> wrote:

> +unsigned int
> +_bfd_elf_default_count_output_relocs (
> +  struct bfd_link_info *info ATTRIBUTE_UNUSED, asection *o)
> +{
> +  struct bfd_elf_section_data *esdo;
> +  struct bfd_elf_section_reloc_data *reldata;
> +
> +  esdo = elf_section_data (o);
> +  if (esdo->rel.hdr)
> +    reldata = &esdo->rel;
> +  else if (esdo->rela.hdr)
> +    reldata = &esdo->rela;
> +  else
> +    return TRUE;

Returning TRUE in a function that returns a number doesn't make sense.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

References:
- [PATCH] Test also relocations for ARM unwinding section
  - From: Akihiko Odaki
- [PATCH] ARM: Fix relocation of EXIDX sections
  - From: Akihiko Odaki

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]