This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH, binutils/ARM, ping] Remove _S version or MSR/MRS special registers in binutils 2.27
On 15/08/16 17:27, Thomas Preudhomme wrote:
Is the below patch ok for binutils-2_27-branch? Pasting original text again for
When adding support for ARMv8-M in GAS, MRS/MSR special registers were extended
with MSP_S/MSP_NS and PSP_S/PSP_NS. While _NS versions make sense as they
correspond to a different encoding, _S version do not. They are artifacts of
previous version of the patch where a special CLI switch was considered to
assemble ARMv8-M Secure code. In their current form they are a source of
confusion because they would lead to read or write the non secure version of MSP
and PSP when in non secure state.
Since this is early 2.27 days, we believe it to be best to remove them now
rather than keep them in. Patch is in attachment.
On 15/08/16 11:56, Nick Clifton wrote:
*** gas/ChangeLog ***
2016-08-11 Thomas Preud'homme <email@example.com>
* config/tc-arm.c (v7m_psrs): Remove msp_s, MSP_S, psp_s and PSP_S
* testsuite/gas/arm/archv8m-cmse-msr.s: Remove test for above special
* testsuite/gas/arm/archv8m-cmse-msr-base.d: Likewise.
* testsuite/gas/arm/archv8m-cmse-msr-main.d: Likewise.
* testsuite/gas/arm/archv8m-main-dsp-4.d: Likewise.
Is this ok for master and more importantly binutils-2_27-branch?
Approved for mainline. Check with Tristan for the branch, although I do not
forsee any problems.