This is the mail archive of the
mailing list for the binutils project.
[committed] MIPS/GAS: Remove extraneous `install_insn' call from `append_insn'
- From: "Maciej W. Rozycki" <macro at imgtec dot com>
- To: <binutils at sourceware dot org>
- Date: Fri, 8 Jul 2016 14:43:36 +0100
- Subject: [committed] MIPS/GAS: Remove extraneous `install_insn' call from `append_insn'
- Authentication-results: sourceware.org; auth=none
Author: Richard Sandiford <firstname.lastname@example.org>
Date: Wed Mar 9 09:17:02 2005 +0000
MIPS nop-insertion code, add -mfix-vr4130 [5/11]"), and remove a call to
`install_insn' from `append_insn', which as from that change has become
redundant. This is because such a call, to place an instruction's bit
pattern in output, is already made from `move_insn', called from
`add_relaxed_insn' or `add_fixed_insn' as appropriate, either of which
now always is and has to be made from `append_insn' before the repeated
call to `install_insn' is made. Previously the place where this second
invocation is made was the only one where the output stream was updated,
although the update was made inline rather than with a function call.
Remove the repeated call then, to reclaim some performance.
* config/tc-mips.c (append_insn): Remove extraneous
No regressions in usual MIPS testing, committed.
--- binutils.orig/gas/config/tc-mips.c 2016-07-08 11:33:45.735216529 +0100
+++ binutils/gas/config/tc-mips.c 2016-07-08 11:35:26.520284230 +0100
@@ -7481,7 +7481,6 @@ append_insn (struct mips_cl_insn *ip, ex
ip->fixp[i]->fx_tcbit = 1;
- install_insn (ip);
/* Update the register mask information. */
mips_gprmask |= gpr_read_mask (ip) | gpr_write_mask (ip);