This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gold commit] PR 19823: Don't allow COPY relocs to protected symbols

On Mon, Jun 27, 2016 at 10:40:45AM -0700, Cary Coutant wrote:
> Is there any reason we shouldn't just skip that test case for targets
> that don't normally use copy relocs?

I'd be happy with simply skipping the test.  As it is, it is
particularly nasty since failing that one test stops the majority of
the other tests running, even with "make -k".

Like this then?

	* testsuite/ (copy_test_protected): Disable for powerpc.
	* testsuite/ Regenerate.

diff --git a/gold/testsuite/ b/gold/testsuite/
index 25ee126..7edf7a7 100644
--- a/gold/testsuite/
+++ b/gold/testsuite/
@@ -843,6 +843,7 @@ copy_test_2_pic.o: gcctestdir/ld copy_test_2_pic.o
 	$(CXXLINK) -shared copy_test_2_pic.o
 check_SCRIPTS +=
 check_DATA += copy_test_protected.err
 MOSTLYCLEANFILES += copy_test_protected.err
@@ -854,6 +855,7 @@ copy_test_protected.err: copy_test_protected.o gcctestdir/ld
 	  rm -f $@; \
 	  exit 1; \
 if TLS

Alan Modra
Australia Development Lab, IBM

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]