This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH v2] ARC: gas: Generate offset with Default CFA
- From: Nick Clifton <nickc at redhat dot com>
- To: Vineet Gupta <Vineet dot Gupta1 at synopsys dot com>, Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>
- Cc: Cupertino Miranda <Cupertino dot Miranda at synopsys dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Mon, 27 Jun 2016 16:54:14 +0100
- Subject: Re: [PATCH v2] ARC: gas: Generate offset with Default CFA
- Authentication-results: sourceware.org; auth=none
- References: <1467032706-7684-1-git-send-email-vgupta at synopsys dot com> <1467034867-8288-1-git-send-email-vgupta at synopsys dot com>
Hi Vineet,
> gas * config//tc-arc.c (tc_arc_frame_initial_instructions): Use
> cfi_add_CFA_def_cfa to generate default CFA with offset
Approved and applied.
Note:
+ cfi_add_CFA_def_cfa(28, 0);
You need a space between the end of the function name and the opening parenthesis.
Also - you did not test the patch by running the GAS testsuite. If you
had done so you would have found a regression: "CFI on ARC". I have
taken care of this for you this time...
Cheers
Nick