This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 1/3] [ARC] Add arithmetic and logic instructions for nps


Hi Graham,

A small point:

> +#define MAKE_1BASED_INSERT_EXTRACT_FUNCS(NAME,SHIFT,UPPER,BITS)         \
> +static unsigned                                                         \
> +insert_nps_##NAME (unsigned insn ATTRIBUTE_UNUSED,                      \
> +                   int value ATTRIBUTE_UNUSED,                          \
> +                   const char **errmsg ATTRIBUTE_UNUSED)                \
> +{                                                                       \
> +  if (value < 1 || value > UPPER)                                       \
> +    *errmsg = _("Value must be in the range 0 to " #UPPER);             \

If value is zero then the error message will be triggered, but the message
says that zero is a permissible value...

Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]