This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] ld/testsuite/ld-elf/init-fini-arrays.d: Remove `ft32-*-*' xfail


Revert the addition of `ft32-*-*' to this test case made with commit 
d1f70bdcab6c ("Fix lots of linker testsuite failures for the FT32 
target.") as this case scores an XPASS now.

	ld/
	* testsuite/ld-elf/init-fini-arrays.d: Remove `ft32-*-*' xfail.
---
Nick,

 I've rerun cross-target testing now the first time since your recent 
`ft32-elf' target clean-up and I've noticed this change in results:

ft32-elf  +XPASS: ld-elf/init-fini-arrays

I wonder if there's something wrong with `make' dependencies that caused 
you to see a FAIL here.  I actually had to do a fresh build of this target 
to get rid of the very `invalid length for memory region flash' failures 
you had addressed with the said commit, so it looks to me like the change 
to scripttempl/ft32.sc didn't trigger a regeneration of the LD binary for 
some reason.

 Can you please double-check if this XPASS is indeed there with your 
builds too and if so, confirm that this is OK to apply?

  Maciej

binutils-ld-ft32-test-init-fini-arrays.diff
Index: binutils/ld/testsuite/ld-elf/init-fini-arrays.d
===================================================================
--- binutils.orig/ld/testsuite/ld-elf/init-fini-arrays.d	2016-05-19 12:47:45.000000000 +0100
+++ binutils/ld/testsuite/ld-elf/init-fini-arrays.d	2016-05-26 20:18:51.599254694 +0100
@@ -1,9 +1,9 @@
 #source: init-fini-arrays.s
 #ld: -r
 #readelf: -S --wide
-#xfail: cr16-*-* crx-*-* ft32-*-* msp430-*-*
+#xfail: cr16-*-* crx-*-* msp430-*-*
 # msp430 puts the init_array and fini_array inside the .rodata section.
-# cr16, crx and ft32 use non-standard scripts with memory regions, which don't play
+# cr16 and crx use non-standard scripts with memory regions, which don't play
 #  well with unique group sections under ld -r.
 
 #...


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]