This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] make the type of nds32_pseudo_opcode::pseudo_val unsigned


Hi Trev,

> built and regtested nds32be-elf, ok?

Not sure...

> @@ -2106,7 +2106,7 @@ struct nds32_pseudo_opcode
>    const char *opcode;
>    int argc;
>    nds32_pseudo_opcode_func proc;
> -  int pseudo_val;
> +  unsigned int pseudo_val;
>  

I think that you ought to change the type of the pv parameter of the
nds32_pseudo_opcode_func as well, and then trickle the change down into
the pseudo functions as well.  Ie be consistent in the type of this 
variable.

Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]