This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH 4/4] gas/arc: Make member of arc_flags const

By making the flgp field of struct arc_flags constant we can remove a
place where we cast away the const-ness of a variable.  Also, given that
the value assigned to this field almost always comes from compile-time
constant data, having the field non-constant is probably a bad thing.


	* config/tc-arc.c (find_opcode_match): Remove casting away of
	* config/tc-arc.h (struct arc_flags): Make flgp field const.
 gas/ChangeLog       | 6 ++++++
 gas/config/tc-arc.c | 2 +-
 gas/config/tc-arc.h | 2 +-
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/gas/config/tc-arc.c b/gas/config/tc-arc.c
index b217e06..eca6817 100644
--- a/gas/config/tc-arc.c
+++ b/gas/config/tc-arc.c
@@ -1884,7 +1884,7 @@ find_opcode_match (const struct arc_opcode_hash_entry *entry,
 		      if (pflag->flgp != NULL)
 			goto match_failed;
-		      pflag->flgp = (struct arc_flag_operand *) flg_operand;
+		      pflag->flgp = flg_operand;
 		      break; /* goto next flag class and parsed flag.  */
diff --git a/gas/config/tc-arc.h b/gas/config/tc-arc.h
index 16f6a06..b61342b 100644
--- a/gas/config/tc-arc.h
+++ b/gas/config/tc-arc.h
@@ -225,7 +225,7 @@ struct arc_flags
   char name[MAX_FLAG_NAME_LENGTH + 1];
   /* Pointer to arc flags.  */
-  struct arc_flag_operand *flgp;
+  const struct arc_flag_operand *flgp;
 extern const relax_typeS md_relax_table[];

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]