This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH 2/2] LD/testsuite: Expand STB_GNU_UNIQUE test coverage
- From: "Maciej W. Rozycki" <macro at imgtec dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: <binutils at sourceware dot org>
- Date: Fri, 6 May 2016 18:16:36 +0100
- Subject: Re: [PATCH 2/2] LD/testsuite: Expand STB_GNU_UNIQUE test coverage
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 00 dot 1605032355130 dot 6794 at tp dot orcam dot me dot uk> <alpine dot DEB dot 2 dot 00 dot 1605040010060 dot 6794 at tp dot orcam dot me dot uk> <04428692-b013-06bd-d62e-67f79eff5446 at redhat dot com>
> > So does anybody actually know why the current per-architecture approach
> > was accepted in the review?
> No. My guess is that it was not thought through properly. Possibly a
> developer wanted it for their architecture, but did not consider the impact
> on other architectures. So their patch went in for their architecture and
> the feature proved to be useful. Then users for other architectures (probably
> kernel and library builders) decided that they wanted it too, and so a
> piecemeal set of hacks were added to accommodate them. Just a guess mind...
Thank you for your confirmation, I suspected this might have been the
> > If not then I'll post a proposal separately to gather all the bits
> > scattered across target `*_add_symbol_hook' handlers and handle this
> > feature in `elf_link_add_object_symbols'.
> Please do.
I've got the test suite part done already, so I'll update code and post
the two changes together. I think it'll be the best if the code update
goes in first or both are a single change, so as not to cause regressions
which might break bisection.