This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] LD/testsuite: Expand STB_GNU_UNIQUE test coverage


Hi Pedro,

> > though, or maybe even make another De Morgan transformation and have a 
> > single negation at the then outermost level.  Keeping the `*-*-elf*' 
> > exceptions on a single line might improve readability, although it'll be 
> > lost with the first addition of another exception.
> 
> Or add a proc, which then allows early returns, making it
> more readable, IMO:

 I like your proposal better, thanks for the suggestion.  Although I'll 
shuffle the conditions a bit, to reproduce the original semantics I 
proposed -- for GNU targets we do want to report STB_GNU_UNIQUE support 
unconditionally, no exceptions.

 I'll wait a couple of days for any response to my questions and post an
updated version then.

  Maciej


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]