This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH 2/2] LD/testsuite: Expand STB_GNU_UNIQUE test coverage
- From: "Maciej W. Rozycki" <macro at imgtec dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Matthew Fortune <Matthew dot Fortune at imgtec dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Wed, 4 May 2016 22:35:27 +0100
- Subject: Re: [PATCH 2/2] LD/testsuite: Expand STB_GNU_UNIQUE test coverage
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 00 dot 1605032355130 dot 6794 at tp dot orcam dot me dot uk> <alpine dot DEB dot 2 dot 00 dot 1605040010060 dot 6794 at tp dot orcam dot me dot uk> <6D39441BF12EF246A7ABCE6654B023537E3F7E91 at hhmail02 dot hh dot imgtec dot org> <alpine dot DEB dot 2 dot 00 dot 1605041509120 dot 6794 at tp dot orcam dot me dot uk> <7ffd1ea1-8b53-f43b-8a20-6236fd52de21 at redhat dot com>
> > though, or maybe even make another De Morgan transformation and have a
> > single negation at the then outermost level. Keeping the `*-*-elf*'
> > exceptions on a single line might improve readability, although it'll be
> > lost with the first addition of another exception.
> Or add a proc, which then allows early returns, making it
> more readable, IMO:
I like your proposal better, thanks for the suggestion. Although I'll
shuffle the conditions a bit, to reproduce the original semantics I
proposed -- for GNU targets we do want to report STB_GNU_UNIQUE support
unconditionally, no exceptions.
I'll wait a couple of days for any response to my questions and post an
updated version then.