This is the mail archive of the
mailing list for the binutils project.
Re: [RFC][PATCH] Check ELF relocs after opening all all input files
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: Alan Modra <amodra at gmail dot com>, Binutils <binutils at sourceware dot org>
- Date: Thu, 21 Apr 2016 04:18:47 -0700
- Subject: Re: [RFC][PATCH] Check ELF relocs after opening all all input files
- Authentication-results: sourceware.org; auth=none
- References: <20160419134956 dot GA12310 at intel dot com> <57165642 dot 1070808 at redhat dot com> <CAMe9rOrydGcortz2AsujVSQYZCRbSPsi7CFQRnA6ZZiicbUvTA at mail dot gmail dot com> <20160419232457 dot GB20119 at bubble dot grove dot modra dot org> <CAMe9rOrQ3QqrBmw206e3_F1f3zbnS7+tUGh5MxmUq-Z_EQskYQ at mail dot gmail dot com> <CAMe9rOqxcN=nG3mGpb_tgVrdxQTuJY1jF_=EmZGBXJT7OkewmA at mail dot gmail dot com> <5718AC69 dot 2020604 at redhat dot com> <5718AD0C dot 4060003 at redhat dot com>
On Thu, Apr 21, 2016 at 3:35 AM, Nick Clifton <firstname.lastname@example.org> wrote:
> Hi H.J.
> Ooo - I forgot to mention one other feature of the patch, which
> you might find objectionable. It changes the loop in lang_check_relocs()
> so that it does not terminate when a reloc check fails. Instead
> I thought it better to carry on processing the remaining bfds, in
> case there are further errors that can be reported to the user.
It is OK as long as there is no regression. BTW, you
&& bfd_get_flavour (link_info.output_bfd) == bfd_target_elf_flavour)
before the loop.