This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/2] [PUSHED/OBV] gas/arc: Add nps400 support to .cpu directive

* Claudiu Zissulescu <> [2016-04-17 10:35:16 +0200]:

> Hi,
> I am not sure if those two patches are obvious. One is changing the
> semantic of a pseudo-op. I would expect a bit of discussion here, as
> in our ARC backend R0 is a symbol while r0 is a register. Hence, we
> are case sensitive. And the other one adds (doesn't fix) a new
> feature.

I apologise if I have overstepped the mark with these commits.

The change in case sensitivity brings the '.cpu' directive into line
with the -mcpu command line option.

Claudiu, you make it clear in the above that you _could_ object to
this commit, however, even after reading the above a couple of times,
it's not clear if you are actually objecting or not.  If you don't
like the commit then please make an objection, the commit can always
be reverted.

You are right that adding support for nps400 to the .cpu directive is
not a bug fix, however, the code is trivial, follow the existing
pattern of code in that function, and given that nps400 has been
accepted I am curious under what situation you think that that part of
the commit would be objected to in any way?

Again, I apologise if anyone feels I was too forward in pushing these
patches, I certainly did not intend to cause any offence.


> Nick should be the one if I am right or not.
> Cheers,
> Claudiu
> On Sat, Apr 16, 2016 at 6:01 PM, Andrew Burgess
> <> wrote:
> > Two patches that I've pushed relating to adding support for nps400 to
> > the ARC assembler .cpu directive.  The first patch adds support for
> > nps400 while the second makes the .cpu directive case-insensitive.
> >
> > I've pushed both of these fixes as obvious.
> >
> > ---
> >
> > Andrew Burgess (2):
> >   gas/arc: Support NPS400 in .cpu directive
> >   gas/arc: Make .cpu directive case-insensitive
> >
> >  gas/ChangeLog       |  9 +++++++++
> >  gas/config/tc-arc.c | 18 +++++++++++-------
> >  2 files changed, 20 insertions(+), 7 deletions(-)
> >
> > --
> > 2.6.4
> >

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]