This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCHv2 1/3] opcodes/arc: Move instruction length logic to new function
- From: Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: "Cupertino dot Miranda at synopsys dot com" <Cupertino dot Miranda at synopsys dot com>, "noamca at mellanox dot com" <noamca at mellanox dot com>
- Date: Tue, 12 Apr 2016 12:27:39 +0000
- Subject: RE: [PATCHv2 1/3] opcodes/arc: Move instruction length logic to new function
- Authentication-results: sourceware.org; auth=none
- References: <1460027127-1121-1-git-send-email-andrew dot burgess at embecosm dot com> <cover dot 1460458691 dot git dot andrew dot burgess at embecosm dot com> <cb64992909da171def628e036ee5f6cc94e71058 dot 1460458691 dot git dot andrew dot burgess at embecosm dot com>
Hi Andrew,
> + case bfd_mach_arc_nps400:
> + case bfd_mach_arc_arc700:
> + case bfd_mach_arc_arc600:
> + len = (major_opcode > 0xb) ? 2 : 4;
> + break;
Ok, this solves the hole between 0x07 and 0x0b existing in your former proposal. I think this implementation is safer than the older proposal and nicer than original code.
Cheers,
Claudiu