This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH] [ARC] Add new ARC EM opcodes.
- From: Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>
- To: Nick Clifton <nickc at redhat dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: "Francois dot Bedard at synopsys dot com" <Francois dot Bedard at synopsys dot com>
- Date: Thu, 10 Mar 2016 11:30:47 +0000
- Subject: RE: [PATCH] [ARC] Add new ARC EM opcodes.
- Authentication-results: sourceware.org; auth=none
- References: <1456405905-30875-1-git-send-email-claziss at synopsys dot com> <098ECE41A0A6114BB2A07F1EC238DE896617A9D7 at DE02WEMBXB dot internal dot synopsys dot com> <56E02FAD dot 4060400 at redhat dot com>
Hi Nick,
Thank you for the clarifications.
> >> +++ b/include/opcode/arc.h
> >> @@ -66,7 +66,8 @@ typedef enum
> >> SHFT1,
> >> SHFT2,
> >> SWAP,
> >> - SP
> >> + SP,
> >> + QUARKSE
> >> } insn_subclass_t;
>
> This enum was alpha- sorted before this change. Is there any particular
> reason for
> removing that property ?
No, I will add it to its proper position.
>
>
> >> +/* QuarkSE specific instructions. */
> >> +{"dsp_fp_div", 0x382A0000, 0xF8FF0000, ARC_OPCODE_ARCv2EM,
> FLOAT,
> >> QUARKSE, { RA, RB, RC }, { C_F }},
>
> Given that there is so much repetition in these new entries, wouldn't it make
> sense
> to use a couple of macros to automate most of the fields ? There is less
> chance for
> typographical errors that way too.
I will try to get some sort of macro expansion for those regular instructions. Usually, I am getting those instructions in a tab-form from hardware team. So, it is pretty easy for me just to dump them as they arrive.
Best,
Claudiu