This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH 06/13] make various variables in gas const
- From: Trevor Saunders <tbsaunde at tbsaunde dot org>
- To: Hans-Peter Nilsson <hp at bitrange dot com>
- Cc: tbsaunde+binutils at tbsaunde dot org, binutils at sourceware dot org
- Date: Mon, 22 Feb 2016 20:23:17 -0500
- Subject: Re: [PATCH 06/13] make various variables in gas const
- Authentication-results: sourceware.org; auth=none
- References: <1456106533-19089-1-git-send-email-tbsaunde+binutils at tbsaunde dot org> <1456106533-19089-7-git-send-email-tbsaunde+binutils at tbsaunde dot org> <alpine dot BSF dot 2 dot 02 dot 1602221930490 dot 74301 at arjuna dot pair dot com>
On Mon, Feb 22, 2016 at 07:37:21PM -0500, Hans-Peter Nilsson wrote:
> On Sun, 21 Feb 2016, email@example.com wrote:
> > From: Trevor Saunders <firstname.lastname@example.org>
> > gas/ChangeLog:
> > * config/tc-mmix.c (mmix_handle_mmixal): Likewise.
> I like your work, but please use "char *foo", not "char * foo".
> It's kind-of a nit (...) but not completely so.
> 1. Consistency with the rest of that file.
> 2. Misleading; you can't write "char * foo, bar;" (or even
> worse, "char* foo, bar;") to declare foo and bad both char
> pointers, you have to write "char *foo, *bar;".
> Ergo the "*" "belongs" to the name, in non-standardese terms.
So, personally I agree with you, but I do so love how different people
have different opinions (see
http://sourceware.org/ml/binutils/2016-02/msg00277.html). However I
admit I was rather random in following that style or not.
> brgds, H-P