This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 06/13] make various variables in gas const
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: tbsaunde+binutils at tbsaunde dot org
- Cc: binutils at sourceware dot org
- Date: Mon, 22 Feb 2016 19:37:21 -0500 (EST)
- Subject: Re: [PATCH 06/13] make various variables in gas const
- Authentication-results: sourceware.org; auth=none
- References: <1456106533-19089-1-git-send-email-tbsaunde+binutils at tbsaunde dot org> <1456106533-19089-7-git-send-email-tbsaunde+binutils at tbsaunde dot org>
On Sun, 21 Feb 2016, tbsaunde+binutils@tbsaunde.org wrote:
> From: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
>
> gas/ChangeLog:
> * config/tc-mmix.c (mmix_handle_mmixal): Likewise.
I like your work, but please use "char *foo", not "char * foo".
It's kind-of a nit (...) but not completely so.
1. Consistency with the rest of that file.
2. Misleading; you can't write "char * foo, bar;" (or even
worse, "char* foo, bar;") to declare foo and bad both char
pointers, you have to write "char *foo, *bar;".
Ergo the "*" "belongs" to the name, in non-standardese terms.
brgds, H-P