This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH] Move 'enum bfd_endian' to a non-generated header
- From: Pedro Alves <palves at redhat dot com>
- To: Nick Clifton <nickc at redhat dot com>, Tristan Gingold <gingold at adacore dot com>, binutils at sourceware dot org
- Date: Thu, 18 Feb 2016 17:14:40 +0000
- Subject: Re: [PATCH] Move 'enum bfd_endian' to a non-generated header
- Authentication-results: sourceware.org; auth=none
- References: <1455302366-15480-1-git-send-email-palves at redhat dot com> <1CBD08FF-499B-46BA-95E8-4C38BA1B4EFE at adacore dot com> <56C5DC52 dot 50201 at redhat dot com> <56C5E013 dot 2040909 at redhat dot com> <20160218160825 dot GB7732 at vapier dot lan>
On 02/18/2016 04:08 PM, Mike Frysinger wrote:
> On 18 Feb 2016 15:15, Pedro Alves wrote:
>> On 02/18/2016 02:59 PM, Nick Clifton wrote:
>>> Also - why create a new header file ? Why not just add it to bfdlink.h ?
>> Unfortunately that wouldn't work, because bfdlink.h depends on types that
>> depend on bfd being configured. E.g., bfd_vma.
> since bfd.h is already a generated header from multiple inputs, why not
> create a new bfd-in-plain.h (or whatever) file that also gets gathered ?
> then code in-tree can include that directly and out of tree users do not
> need to change anything.
Because I didn't know this was an issue, but I agree that sounds like a good
idea. I'll give that a try.
>>> (New header files are a pain for toolchain releases and distribution
> this is significant. off the top of my head, there's a few places in
> Gentoo i'd have to adjust, and do so dynamically (since we support old
> versions too).