This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Bootstrap failure because of warning in tc-i386.c


On Fri, Dec 18, 2015 at 9:57 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Dec 18, 2015 at 6:04 AM, Nick Clifton <nickc@redhat.com> wrote:
>> Hi H.J.
>>
>>>>    I was trying to bootstrap the current mainline FSF gcc sources
>>>>    yesterday, using a combined tree with the latest binutils sources,
>>>>    when I ran into this error:
>>
>>
>>> Can you tell me how to reproduce it?  I will take care of it.
>>
>>
>> Bootstrap a 32-bit gcc on an x86_64 host using an integrated set of sources
>> for mainline GCC and BINUTILS.  The failure should appear.
>>
>> Specifically I am running this script:
>>
>> #!/bin/bash
>>
>> CC="gcc -m32" CXX="g++ -m32" ABI="32" setarch i686 \
>> /work/sources/gcc/current/configure \
>>   --enable-languages=c,c++ \
>>   --with-x=no \
>>   --disable-multilib \
>>   --prefix=`pwd`/install \
>>   --quiet
>>
>> make clean stage3-bubble
>>
>
> I am testing this.
>

This is what I checked in.


-- 
H.J.
From a28def75916fb4fa8280404f8c023adc0773162d Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Fri, 18 Dec 2015 14:03:43 -0800
Subject: [PATCH] Process 64-bit imm/disp only for 64-bit BFD

We only need to store 32-bit immediate in 64-bit and optimize 64-bit
displacement to 32-bit only for 64-bit BFD.

	* config/tc-i386.c (optimize_imm): Store 32-bit immediate in
	64-bit only for 64-bit BFD
	(optimize_disp): Optimize 64-bit displacement to 32-bit only
	for 64-bit BFD.
---
 gas/ChangeLog        | 7 +++++++
 gas/config/tc-i386.c | 6 ++++++
 2 files changed, 13 insertions(+)

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 3147d22..e80a36d 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,10 @@
+2015-12-18  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* config/tc-i386.c (optimize_imm): Store 32-bit immediate in
+	64-bit only for 64-bit BFD.
+	(optimize_disp): Optimize 64-bit displacement to 32-bit only
+	for 64-bit BFD.
+
 2015-12-17  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
 
 	* gas/config/tc-arm.c (aeabi_set_public_attributes): Adjust
diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c
index 1573043..4940a80 100644
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -4218,6 +4218,8 @@ optimize_imm (void)
 		i.op[op].imms->X_add_number =
 		  (((i.op[op].imms->X_add_number & 0xffff) ^ 0x8000) - 0x8000);
 	      }
+#ifdef BFD64
+	    /* Store 32-bit immediate in 64-bit for 64-bit BFD.  */
 	    if ((i.types[op].bitfield.imm32)
 		&& ((i.op[op].imms->X_add_number & ~(((offsetT) 2 << 31) - 1))
 		    == 0))
@@ -4226,6 +4228,7 @@ optimize_imm (void)
 						^ ((offsetT) 1 << 31))
 					       - ((offsetT) 1 << 31));
 	      }
+#endif
 	    i.types[op]
 	      = operand_type_or (i.types[op],
 				 smallest_imm_type (i.op[op].imms->X_add_number));
@@ -4306,6 +4309,8 @@ optimize_disp (void)
 		op_disp = (((op_disp & 0xffff) ^ 0x8000) - 0x8000);
 		i.types[op].bitfield.disp64 = 0;
 	      }
+#ifdef BFD64
+	    /* Optimize 64-bit displacement to 32-bit for 64-bit BFD.  */
 	    if (i.types[op].bitfield.disp32
 		&& (op_disp & ~(((offsetT) 2 << 31) - 1)) == 0)
 	      {
@@ -4316,6 +4321,7 @@ optimize_disp (void)
 		op_disp = (op_disp ^ ((offsetT) 1 << 31)) - ((addressT) 1 << 31);
 		i.types[op].bitfield.disp64 = 0;
 	      }
+#endif
 	    if (!op_disp && i.types[op].bitfield.baseindex)
 	      {
 		i.types[op].bitfield.disp8 = 0;
-- 
2.5.0


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]