This is the mail archive of the
mailing list for the binutils project.
Re: [RFC PATCH 04/11] MIPS/BFD: Fold the handling of input MIPS ABI flags together
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: "Maciej W. Rozycki" <macro at imgtec dot com>
- Cc: <binutils at sourceware dot org>, Matthew Fortune <Matthew dot Fortune at imgtec dot com>, Daniel Sanders <Daniel dot Sanders at imgtec dot com>
- Date: Tue, 15 Dec 2015 21:23:04 +0000
- Subject: Re: [RFC PATCH 04/11] MIPS/BFD: Fold the handling of input MIPS ABI flags together
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 00 dot 1511200755190 dot 6915 at tp dot orcam dot me dot uk> <alpine dot DEB dot 2 dot 00 dot 1511200816000 dot 6915 at tp dot orcam dot me dot uk>
"Maciej W. Rozycki" <firstname.lastname@example.org> writes:
> Fold the handling of input MIPS ABI flags in private BFD data merging
> together, moving the attribute check afterwards, and consequently making
> input vs output compatibility checks only start once all input ABI flag
> data has been gathered, checked for inconsistencies and put in order.
> Consequently also address the issue of input ABI flag inconsistencies
> being masked by a failing attribute check, which currently makes
> `_bfd_mips_elf_merge_private_bfd_data' exit prematurely and therefore
> prevent input ABI flag inconsistencies from being reported. Such
> inconsistencies need to be reported as they may be the very cause of an
> attribute check failure.
Took me a while to realise that this was because the diagnostic reported
by mips_elf_merge_obj_attributes doesn't say anything about attributes.
That seems like the correct choice, but if it had mentioned attributes,
there's an argument that it would be reporting the real problem and that
the warning would simply be another manifestation of the same thing
(and so maybe just noise). But it doesn't, so...
OK independently of the rest, thanks.