This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] [GAS] sparc: support %dN and %qN syntax for FP registers.
- From: Nick Clifton <nickc at redhat dot com>
- To: "Jose E. Marchesi" <jose dot marchesi at oracle dot com>, binutils at sourceware dot org
- Date: Fri, 20 Nov 2015 15:44:54 +0000
- Subject: Re: [PATCH] [GAS] sparc: support %dN and %qN syntax for FP registers.
- Authentication-results: sourceware.org; auth=none
- References: <1447876477-22312-1-git-send-email-jose dot marchesi at oracle dot com>
Hi Jose,
2015-11-18 Jose E. Marchesi <jose.marchesi@oracle.com>
* config/tc-sparc.c (sparc_ip): Support %dN and %qN notation for
double and quad-precision floating-point registers.
Approved - please apply - but ...
+ if (format == 'd' && (mask & 1))
+ {
+ break;
+ }; /* register must be even numbered */
+
+ if (format == 'q' && (mask & 3))
+ {
+ break;
+ } /* register must be even numbered */
+
if ((*args == 'v'
|| *args == 'B'
|| *args == '5'
These two tests could be merged into the tests that follow.
Also it would be nice to fix the comments to follow the coding
guidelines. Ie:
{
/* The register must be even numbered. */
break;
}
Cheers
Nick