This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [GAS] sparc: support %dN and %qN syntax for FP registers.


Hi Jose,

2015-11-18  Jose E. Marchesi  <jose.marchesi@oracle.com>

	* config/tc-sparc.c (sparc_ip): Support %dN and %qN notation for
	double and quad-precision floating-point registers.

Approved - please apply - but ...


+                    if (format == 'd' && (mask & 1))
+                      {
+                        break;
+                      };	/* register must be even numbered */
+
+                    if (format == 'q' && (mask & 3))
+                      {
+                        break;
+                      }		/* register must be even numbered */
+
  		    if ((*args == 'v'
  			 || *args == 'B'
  			 || *args == '5'


These two tests could be merged into the tests that follow.

Also it would be nice to fix the comments to follow the coding guidelines. Ie:

      {
        /* The register must be even numbered.  */
	break;
      }

Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]