This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Missing part from "[PATCH] - objcopy --extract-symbol clears e_flags ELF header field"
- From: Alan Modra <amodra at gmail dot com>
- To: Hans-Peter Nilsson <hp at bitrange dot com>
- Cc: Ronald Hoogenboom <hoogenboom30 at zonnet dot nl>, binutils at sourceware dot org
- Date: Fri, 23 Oct 2015 00:34:09 +1030
- Subject: Re: Missing part from "[PATCH] - objcopy --extract-symbol clears e_flags ELF header field"
- Authentication-results: sourceware.org; auth=none
- References: <561D44BC dot 9080307 at atom dot grundel> <20151014002120 dot GK4434 at bubble dot grove dot modra dot org> <561EB0A7 dot 9000402 at atom dot grundel> <20151015130648 dot GA13961 at bubble dot grove dot modra dot org> <alpine dot BSF dot 2 dot 02 dot 1510200730020 dot 55298 at arjuna dot pair dot com>
On Tue, Oct 20, 2015 at 07:37:07AM -0400, Hans-Peter Nilsson wrote:
> On Thu, 15 Oct 2015, Alan Modra wrote:
> > binutils/
> > * objcopy.c (copy_object): Don't omit bfd_copy_private_bfd_data
> > call when extract_symbol.
>
> Don't you want to remove the exact same lines in setup_section,
> dominating the bfd_copy_private_section_data call there?
>
> Tested native i686-linux, cris-elf and mmix, no regressions.
> I guess you know better which other targets need testing.
>
> binutils:
> * objcopy.c (setup_section): Don't omit bfd_copy_private_bfd_data
> call when extract_symbol.
OK.
--
Alan Modra
Australia Development Lab, IBM