This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 2/2] xtensa: add --auto-litpools option
- From: Max Filippov <jcmvbkbc at gmail dot com>
- To: "augustine dot sterling at gmail dot com" <augustine dot sterling at gmail dot com>
- Cc: binutils at sourceware dot org, David Weatherford <weath at cadence dot com>, Marc Gauthier <marc at cadence dot com>, "linux-xtensa at linux-xtensa dot org" <linux-xtensa at linux-xtensa dot org>
- Date: Wed, 12 Aug 2015 20:25:26 +0300
- Subject: Re: [PATCH 2/2] xtensa: add --auto-litpools option
- Authentication-results: sourceware.org; auth=none
- References: <1439340867-980-1-git-send-email-jcmvbkbc at gmail dot com> <1439340867-980-3-git-send-email-jcmvbkbc at gmail dot com> <CAGSvup_3nhzH3gKcX2bDYMPQKg+q8WPZ+q-E-0ODn01UYeZusQ at mail dot gmail dot com>
On Wed, Aug 12, 2015 at 7:40 PM, augustine.sterling@gmail.com
<augustine.sterling@gmail.com> wrote:
> On Tue, Aug 11, 2015 at 5:54 PM, Max Filippov <jcmvbkbc@gmail.com> wrote:
>> Auto-litpools is the automated version of text-section-literals: literal
>> pool candidate frags are planted every N frags and during relaxation
>> they are turned into actual literal pools where literals are moved to
>> become reachable for their first reference by L32R instruction.
>
> This is a terrific change and a long time in coming. Approved after
> you fix the very minor formatting issue below.
>
>> +struct litpool_frag {
>
> gnu-style requires the brace on a separate line. This happens in a
> couple of spots. Fix those and you are set to go.
Fixed both spots and checked in. Thanks!
-- Max