This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add a versioned field to elf_link_hash_entry


On Fri, Aug 07, 2015 at 05:36:25AM -0700, H.J. Lu wrote:
> +  /* Symbol version information:
> +     0: unknown
> +     1: unversioned
> +     2: versioned
> +   */
> +  unsigned int versioned : 2;
>    /* Symbol should be marked as hidden in the version information.  */
>    unsigned int hidden : 1;

Seems to me it would be better to use an enum, and ENUM_BITFIELD.
Also, I believe "hidden" could be merged into the new field, giving it
four states: unknown, unversioned, versioned, versioned_hidden.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]