This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [MIPS] Reserve a .gnu_attribute value


On Wed, 8 Jul 2015, Richard Sandiford wrote:

> > diff --git a/binutils/readelf.c b/binutils/readelf.c
> > index 398a165..86cfd26 100644
> > --- a/binutils/readelf.c
> > +++ b/binutils/readelf.c
> > @@ -13197,6 +13197,9 @@ print_mips_fp_abi_value (int val)
> >      case Val_GNU_MIPS_ABI_FP_64A:
> >        printf (_("Hard float compat (32-bit CPU, 64-bit FPU)\n"));
> >        break;
> > +    case Val_GNU_MIPS_ABI_FP_NAN2008 :
> > +      printf (_("NaN 2008 compatibility\n"));
> > +      break;
> 
> No space before ":"
> 
> OK with that change, thanks.

 Shouldn't there be more case values?  `Val_GNU_MIPS_ABI_FP_NAN2008' was 
ORed with the lower bits, e.g. `Val_GNU_MIPS_ABI_FP_DOUBLE'.

  Maciej


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]