RE: [MIPS] Reserve a .gnu_attribute value

["Moore, Catherine" <Catherine_Moore at mentor dot com>]

> -----Original Message-----
> From: Richard Sandiford [mailto:richard.sandiford@arm.com]
> Sent: Tuesday, June 23, 2015 4:25 AM
> To: Moore, Catherine
> Cc: binutils@sourceware.org; andrew.bennett@imgtec.com; Matthew
> Fortune
> Subject: Re: [MIPS] Reserve a .gnu_attribute value
> 
> "Moore, Catherine" <Catherine_Moore@mentor.com> writes:
> >
> > I'd like to reserve the value 8 for backwards-object compatibility in
> > the object attribute value enumeration.
> > Our original Nan2008 implementation used this value in the
> > .gnu_attribute section, but the final approved version does not.
> > While it doesn't pose a problem for me today, #8 is the next number in
> > the sequence and I would like to make sure that it doesn't get used
> > for something else.  Does anyone have any objections to this?
> >
> > If there are no objections, I will post a formal patch, along with the
> > required mips attribute testsuite changes.
> 
> Sounds like a good idea to me FWIW.
> 

Here's the patch.  OK to commit?

2015-07-08  Catherine Moore  <clm@codesourcery.com>

        include/
        * elf/mips/mips.h (Val_GNU_MIPS_ABI_FP_NAN2008): New.

        gas/
        * config/tc-mips.c (check_fpabi):  Handle
        VAL_GNU_MIPS_ABI_FP_NAN2008.

        binutils/
        * readelf.c (print_mips_fp_abi_value): Handle
        Val_GNU_MIPS_ABI_FP_NAN2008.

        ld/testsuite/
        * ld-mips-elf/attr-gnu-4-08.d: Update expected output.
        * ld-mips-elf/attr-gnu-4-09.d: New.
        * ld-mips-elf/attr-gnu-4-19.d: New.
        * ld-mips-elf/attr-gnu-4-29.d: New.
        * ld-mips-elf/attr-gnu-4-39.d: New.
        * ld-mips-elf/attr-gnu-4-49.d: New.
        * ld-mips-elf/attr-gnu-4-59.d: New.
        * ld-mips-elf/attr-gnu-4-69.d: New.
        * ld-mips-elf/attr-gnu-4-79.d: New.
        * ld-mips-elf/attr-gnu-4-89.d: New.
        * ld-mips-elf/attr-gnu-4-9.s: New.
        * ld-mips-elf/mips-elf.exp: Run new tests.

Attachment: nan-compat.patch
Description: nan-compat.patch