This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH, ARM] Don't pass incorrect pointer in arm_build_one_stub
- From: "Thomas Preud'homme" <thomas dot preudhomme at arm dot com>
- To: "'Julian Brown'" <julian at codesourcery dot com>, <binutils at sourceware dot org>
- Cc: "Doug Kwan" <dougkwan at google dot com>
- Date: Thu, 2 Jul 2015 18:25:09 +0800
- Subject: RE: [PATCH, ARM] Don't pass incorrect pointer in arm_build_one_stub
- Authentication-results: sourceware.org; auth=none
- References: <20090710141535 dot 6be29db4 at rex dot config>
> From: Julian Brown [mailto:julian@codesourcery.com]
> Sent: Friday, July 10, 2009 9:16 PM
>
> Hi,
Hi Julian,
>
> This patch passes the hash for a symbol from which a stub entry was
> derived, not the hash for the stub entry itself, to
> elf32_arm_final_link_relocate. This fixes a potential incorrect code
> generation issue (not seen on mainline so far, AFAIK). In practice,
> there will be no symbols for the stubs in question, so the value passed
> should always be NULL (though a non-NULL value would be passed prior
> to
> this patch, which could cause elf32_arm_final_link_relocate to get
> confused).
It seems to me that this forbids veneer for global symbols
(stub_entry->h non NULL) with relocations. Why is this safe? I'm hitting
this assert on a patch I'm working on and I don't understand what would
go wrong with a non NULL h.
Best regards,
Thomas