This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: binutils testsuite regressions with your ef10c3ace0067
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Thu, 25 Jun 2015 10:17:39 -0700
- Subject: Re: binutils testsuite regressions with your ef10c3ace0067
- Authentication-results: sourceware.org; auth=none
- References: <201506251618 dot t5PGII2D021899 at ignucius dot se dot axis dot com>
On Thu, Jun 25, 2015 at 9:18 AM, Hans-Peter Nilsson
<hans-peter.nilsson@axis.com> wrote:
> My autotester regports the following regressions for your
> ef10c3ace0067 (Use strtab with GC and suffix merging for .strtab)
> testing binutils:
>
> target mmix-knuth-mmixware
> gas:
> Running /tmp/hpautotest-binutils/bsrc/src/gas/testsuite/gas/mmix/mmix.exp ...
> FAIL: gas/mmix/loc-3
> FAIL: gas/mmix/loc-5
>
> ld:
> Running /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-mmix/mmix.exp ...
> FAIL: ld-mmix/bspec1
> FAIL: ld-mmix/bspec2
> FAIL: ld-mmix/undef-3
>
> target cris-axis-elf:
> ld:
> Running /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-elf/elf.exp ...
> FAIL: ld-elf/strtab
>
> brgds, H-P
I checked in these 2 patches to fix them.
Thanks.
--
H.J.
From 06e78fc77dfcb8a63e44a790c9731db0eaebe87d Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Thu, 25 Jun 2015 10:14:13 -0700
Subject: [PATCH] Run ld-elf/strtab only on linux/gnu targets
Since not all ELF targets support -shared, we limit ld-elf/strtab to
linux and gnu targets.
* ld-elf/strtab.d: Only run on *-*-linux* and *-*-gnu* targets.
---
ld/testsuite/ChangeLog | 4 ++++
ld/testsuite/ld-elf/strtab.d | 1 +
2 files changed, 5 insertions(+)
diff --git a/ld/testsuite/ChangeLog b/ld/testsuite/ChangeLog
index 9beb418..8a6121e 100644
--- a/ld/testsuite/ChangeLog
+++ b/ld/testsuite/ChangeLog
@@ -1,5 +1,9 @@
2015-06-25 H.J. Lu <hongjiu.lu@intel.com>
+ * ld-elf/strtab.d: Only run on *-*-linux* and *-*-gnu* targets.
+
+2015-06-25 H.J. Lu <hongjiu.lu@intel.com>
+
* ld-mmix/bspec1.d: Updated.
* ld-mmix/bspec2.d: Likewise.
* ld-mmix/undef-3.d: Likewise.
diff --git a/ld/testsuite/ld-elf/strtab.d b/ld/testsuite/ld-elf/strtab.d
index 0797708..c1e9096 100644
--- a/ld/testsuite/ld-elf/strtab.d
+++ b/ld/testsuite/ld-elf/strtab.d
@@ -1,5 +1,6 @@
#ld: -shared
#readelf: -W -x .strtab
+#target: *-*-linux* *-*-gnu*
#failif
#...
--
1.9.3
From 4a677ba7249d61afc58b761c997cf1a743279e02 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Thu, 25 Jun 2015 10:05:10 -0700
Subject: [PATCH] Update .strtab section sizes in mmix tests
Since commit ef10c3ace00674e8c3599c3bf95f06c87d68898b may reduce .strtab
section size, we need to adjust expected .strtab section sizes in mmix
tests.
gas/testsuite/
* gas/mmix/loc-3.d: Updated.
* gas/mmix/loc-5.d: Likewise.
ld/testsuite/
* ld-mmix/bspec1.d: Updated.
* ld-mmix/bspec2.d: Likewise.
* ld-mmix/undef-3.d: Likewise.
---
gas/testsuite/ChangeLog | 5 +++++
gas/testsuite/gas/mmix/loc-3.d | 2 +-
gas/testsuite/gas/mmix/loc-5.d | 2 +-
ld/testsuite/ChangeLog | 6 ++++++
ld/testsuite/ld-mmix/bspec1.d | 2 +-
ld/testsuite/ld-mmix/bspec2.d | 2 +-
ld/testsuite/ld-mmix/undef-3.d | 2 +-
7 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/gas/testsuite/ChangeLog b/gas/testsuite/ChangeLog
index 9db7535..9430469 100644
--- a/gas/testsuite/ChangeLog
+++ b/gas/testsuite/ChangeLog
@@ -1,5 +1,10 @@
2015-06-25 H.J. Lu <hongjiu.lu@intel.com>
+ * gas/mmix/loc-3.d: Updated.
+ * gas/mmix/loc-5.d: Likewise.
+
+2015-06-25 H.J. Lu <hongjiu.lu@intel.com>
+
PR gas/18451
* gas/elf/elf.exp: Run strtab.
* gas/elf/strtab.d: New file.
diff --git a/gas/testsuite/gas/mmix/loc-3.d b/gas/testsuite/gas/mmix/loc-3.d
index 1191084..2c477db 100644
--- a/gas/testsuite/gas/mmix/loc-3.d
+++ b/gas/testsuite/gas/mmix/loc-3.d
@@ -17,7 +17,7 @@ Section Headers:
+\[ 5\] \.symtab +SYMTAB +0000000000000000 .*
+00000000000000c0 +0000000000000018 +6 +5 +8
+\[ 6\] \.strtab +STRTAB +0000000000000000 .*
- +0000000000000030 +0000000000000000 +0 +0 +1
+ +000000000000002e +0000000000000000 +0 +0 +1
Key to Flags:
#...
diff --git a/gas/testsuite/gas/mmix/loc-5.d b/gas/testsuite/gas/mmix/loc-5.d
index eec81ad..fa80a86 100644
--- a/gas/testsuite/gas/mmix/loc-5.d
+++ b/gas/testsuite/gas/mmix/loc-5.d
@@ -17,7 +17,7 @@ Section Headers:
+\[ 5\] \.symtab +SYMTAB +0+ .*
+0+c0 +0+18 +6 +6 +8
+\[ 6\] \.strtab +STRTAB +0+ .*
- +0+29 +0+ +0 +0 +1
+ +0+27 +0+ +0 +0 +1
Key to Flags:
#...
diff --git a/ld/testsuite/ChangeLog b/ld/testsuite/ChangeLog
index abc431e..9beb418 100644
--- a/ld/testsuite/ChangeLog
+++ b/ld/testsuite/ChangeLog
@@ -1,5 +1,11 @@
2015-06-25 H.J. Lu <hongjiu.lu@intel.com>
+ * ld-mmix/bspec1.d: Updated.
+ * ld-mmix/bspec2.d: Likewise.
+ * ld-mmix/undef-3.d: Likewise.
+
+2015-06-25 H.J. Lu <hongjiu.lu@intel.com>
+
PR gas/18451
* ld-elf/strtab.d: New file.
* ld-elf/strtab.s: Likewise.
diff --git a/ld/testsuite/ld-mmix/bspec1.d b/ld/testsuite/ld-mmix/bspec1.d
index 784ed55..6440bbe 100644
--- a/ld/testsuite/ld-mmix/bspec1.d
+++ b/ld/testsuite/ld-mmix/bspec1.d
@@ -19,7 +19,7 @@ Section Headers:
+\[ 4\] \.symtab +SYMTAB +0+ .*
+0+d8 +0+18 +5 +3 +8
+\[ 5\] \.strtab +STRTAB +0+ .*
- +0+2d +0+ +0 +0 +1
+ +0+26 +0+ +0 +0 +1
Key to Flags:
#...
diff --git a/ld/testsuite/ld-mmix/bspec2.d b/ld/testsuite/ld-mmix/bspec2.d
index 85d847d..e881b08 100644
--- a/ld/testsuite/ld-mmix/bspec2.d
+++ b/ld/testsuite/ld-mmix/bspec2.d
@@ -24,7 +24,7 @@ Section Headers:
+\[ 5\] \.symtab +SYMTAB +0+ .*
+0+108 +0+18 +6 +4 +8
+\[ 6\] \.strtab +STRTAB +0+ .*
- +0+32 +0+ +0 +0 +1
+ +0+2b +0+ +0 +0 +1
Key to Flags:
#...
diff --git a/ld/testsuite/ld-mmix/undef-3.d b/ld/testsuite/ld-mmix/undef-3.d
index c0352a6..94eeeaa 100644
--- a/ld/testsuite/ld-mmix/undef-3.d
+++ b/ld/testsuite/ld-mmix/undef-3.d
@@ -16,7 +16,7 @@ Section Headers:
+\[ 3\] \.symtab +SYMTAB +0+ .*
+0+a8 +0+18 +4 +2 +8
+\[ 4\] \.strtab +STRTAB +0+ .*
- +0+28 +0+ +0 +0 +1
+ +0+21 +0+ +0 +0 +1
Key to Flags:
#...
--
1.9.3