This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Compact EH binutils patch
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: "Moore, Catherine" <Catherine_Moore at mentor dot com>
- Cc: Nicholas Clifton <nickc at redhat dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Wed, 24 Jun 2015 15:18:11 -0700
- Subject: Re: Compact EH binutils patch
- Authentication-results: sourceware.org; auth=none
- References: <FD3DCEAC5B03E9408544A1E416F112420192C304BB at NA-MBX-01 dot mgc dot mentorg dot com>
On Fri, May 22, 2015 at 12:50 PM, Moore, Catherine
<Catherine_Moore@mentor.com> wrote:
>
> This comment did not make it to the list, so I'm copying it now.
>
> Hi Nick,
> Thank you for reviewing this patch.
> I've now fixed these regressions and the patch has been rebased. I'm attaching the updated patch for review.
> Will you please let me know if it's okay to commit?
> Thanks,
> Catherine
>
> -----Original Message-----
> From: Nicholas Clifton [mailto:nickc@redhat.com]
> Sent: Monday, May 11, 2015 12:29 PM
>
> Hi Catherine,
>
> Sorry for the delay in getting back to you. I have been going through the patch, trying to understand what it is doing. It looks basically sound to me, but there is one problem - it introduces some regressions in my binutils testsuite checker. Specifically:
>
> Checking Binutils in: alpha-linux-gnu ... GAS: 3 LD: 3 done
> GAS REGRESSION: alpha elf-reloc-8
> GAS REGRESSION: CFI on alpha
> GAS REGRESSION: CFI on alpha, 2
> LD REGRESSION: TLS -fpic -shared
> LD REGRESSION: TLS -fpic and -fno-pic exec
> LD REGRESSION: TLS -fpic and -fno-pic exec
>
> Checking Binutils in: alpha-unknown-freebsd4.7 ... GAS: 1 done
> GAS REGRESSION: alpha elf-reloc-8
>
> Checking Binutils in: mips-sgi-irix6 ... GAS: 78 LD: 51 BIN: 2 done
> GAS REGRESSION: Compact EH EB #1 with
> GAS REGRESSION: Compact EH EB #2 with
> GAS REGRESSION: Compact EH EB #3 with
> GAS REGRESSION: Compact EH EB #4 with
> GAS REGRESSION: Compact EH EB #5 with
> GAS REGRESSION: Compact EH EB #6 with
> GAS REGRESSION: Compact EH EB #7 with
> GAS REGRESSION: Compact EH EL #1 with
> GAS REGRESSION: Compact EH EL #2 with
> GAS REGRESSION: Compact EH EL #3 with
> GAS REGRESSION: Compact EH EL #4 with
> GAS REGRESSION: Compact EH EL #5 with
> GAS REGRESSION: Compact EH EL #6 with
> GAS REGRESSION: Compact EH EL #7 with
>
> Could you have a look at these and see what is causing them/how to fix them ? I can provide you with the log files if it will help.
>
> Cheers
> Nick
>
This gas/doc/as.texinfo change:
@subsection @code{.cfi_lsda @var{encoding} [, @var{exp}]}
+@section @code{.cfi_lsda @var{encoding} [, @var{exp}]}
@code{.cfi_lsda} defines LSDA and its encoding.
shouldn't be there. I am checking in this patch to remove it.
--
H.J.
---
diff --git a/gas/doc/as.texinfo b/gas/doc/as.texinfo
index 6694b23..f42979a 100644
--- a/gas/doc/as.texinfo
+++ b/gas/doc/as.texinfo
@@ -4680,7 +4680,6 @@ Only valid when generating compact EH frames (i.e.
with @code{.cfi_sections eh_frame_entry}.
@subsection @code{.cfi_lsda @var{encoding} [, @var{exp}]}
-@section @code{.cfi_lsda @var{encoding} [, @var{exp}]}
@code{.cfi_lsda} defines LSDA and its encoding.
@var{encoding} must be a constant determining how the LSDA
should be encoded. If it is 255 (@code{DW_EH_PE_omit}), the second