This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi Stephen,
The memory allocated for .idata$6 in dlltool isn't cleared before use, which can result in random data remaining after the import names. (I noticed this when working on making DLLs build reproducibly.) The following patch just memsets the allocated memory.
Thanks. You could have also just changed the xmalloc to xcalloc, but there is just a minor point.
I have gone ahead and applied your patch along with this changelog entry. Cheers Nick binutils/ChangeLog 2015-05-29 Stephen Kitt <steve@sk2.org> * dlltool.c (make_one_lib_file): Clear .idata$6 before use.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |