This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH, MIPS] Improve warning messages for la/dla
- From: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- To: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: Richard Sandiford <rdsandiford at googlemail dot com>
- Date: Thu, 23 Apr 2015 19:49:46 +0000
- Subject: [PATCH, MIPS] Improve warning messages for la/dla
- Authentication-results: sourceware.org; auth=none
I've had some feedback from long term MIPS users who have only previously
used MIPS32 and are now looking at MIPS64. The LA and DLA macros have
caused some confusion and I believe a bit of extra guidance in the warning
messages for these will help steer people to the correct fix.
OK to commit?
Thanks,
Matthew
gas/
* config/tc-mips.c (macro): State the recommended way of creating
32-bit or 64-bit addresses.
---
gas/config/tc-mips.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c
index e61bb4d..40e38f8 100644
--- a/gas/config/tc-mips.c
+++ b/gas/config/tc-mips.c
@@ -10331,10 +10331,12 @@ macro (struct mips_cl_insn *ip, char *str)
breg = op[2];
if (dbl && GPR_SIZE == 32)
- as_warn (_("dla used to load 32-bit register"));
+ as_warn (_("dla used to load 32-bit register; recommend using la "
+ "instead"));
if (!dbl && HAVE_64BIT_OBJECTS)
- as_warn (_("la used to load 64-bit address"));
+ as_warn (_("la used to load 64-bit address; recommend using dla "
+ "instead"));
if (small_offset_p (0, align, 16))
{
--
2.2.1