This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Ping [PATCH, h8300] Add h8300-*-linux

From: Yoshinori Sato <ysato at users dot sourceforge dot jp>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: Nicholas Clifton <nickc at redhat dot com>, Binutils <binutils at sourceware dot org>
Date: Thu, 26 Feb 2015 14:51:22 +0900
Subject: Re: Ping [PATCH, h8300] Add h8300-*-linux
Authentication-results: sourceware.org; auth=none
References: <87y4owkydf dot wl-ysato at users dot sourceforge dot jp> <874mr69mva dot wl-ysato at users dot sourceforge dot jp> <54EB5E2A dot 8030209 at redhat dot com> <87bnkjw9kl dot wl-ysato at users dot sourceforge dot jp> <54ECA9B9 dot 2020305 at redhat dot com> <871tle39by dot wl-ysato at users dot sourceforge dot jp> <CAMe9rOrcT-Pw+U=UiDje0B8RVAQO0g4PjReNUoSCSjsGB2A_4Q at mail dot gmail dot com>

At Wed, 25 Feb 2015 11:07:04 -0800,
H.J. Lu wrote:
> 
> On Tue, Feb 24, 2015 at 8:26 PM, Yoshinori Sato
> <ysato@users.sourceforge.jp> wrote:
> > At Tue, 24 Feb 2015 16:41:29 +0000,
> > Nicholas Clifton wrote:
> >>
> >> Hi Sato-san,
> >>
> >> >> I have applied the patch, but there were a few minor problems that
> >> >> needed to be fixed:
> >> >
> >> > I will fix and resend.
> >>
> >> No need - I have already made the relevant changes.
> >
> > OK. Thanks.
> >
> 
> I got
> 
> make[4]: Entering directory `/export/build/gnu/binutils/build-x86_64-linux/ld'
> Makefile:2810: warning: overriding recipe for target `eh8300elf_linux.c'
> Makefile:2163: warning: ignoring old recipe for target `eh8300elf_linux.c'
> Makefile:2821: warning: overriding recipe for target `eh8300helf_linux.c'
> Makefile:2163: warning: ignoring old recipe for target `eh8300helf_linux.c'
> Makefile:2839: warning: overriding recipe for target `eh8300self_linux.c'
> Makefile:2163: warning: ignoring old recipe for target `eh8300self_linux.c'
> Makefile:2857: warning: overriding recipe for target `eh8300sxelf_linux.c'
> Makefile:2163: warning: ignoring old recipe for target `eh8300sxelf_linux.c'
> 
> which is caused by
> 
> eh8300elf_linux.c: $(srcdir)/emulparams/h8300elf_linux.sh \
>   $(ELF_DEPS) $(srcdir)/scripttempl/elf.sc ${GEN_DEPENDS}
>         ${GENSCRIPTS} h8300elf_linux "$(tdir_h8300elf)"
> 
> eh8300helf_linux.c: $(srcdir)/emulparams/h8300helf_linux.sh \
>   $(srcdir)/emulparams/h8300elf_linux.sh \
>   $(ELF_DEPS) $(srcdir)/scripttempl/elf.sc ${GEN_DEPENDS}
>         ${GENSCRIPTS} h8300helf_linux "$(tdir_h8300helf)"
> 
> eh8300self_linux.c: $(srcdir)/emulparams/h8300self_linux.sh \
>   $(srcdir)/emulparams/h8300elf.sh \
>   $(ELF_DEPS) $(srcdir)/scripttempl/elf.sc ${GEN_DEPENDS}
>         ${GENSCRIPTS} h8300self_linux "$(tdir_h8300self)"
> 
> eh8300sxelf_linux.c: $(srcdir)/emulparams/h8300sxelf_linux.sh \
>   $(srcdir)/emulparams/h8300elf.sh \
>   $(ELF_DEPS) $(srcdir)/scripttempl/elf.sc ${GEN_DEPENDS}
>         ${GENSCRIPTS} h8300sxelf_linux "$(tdir_h8300sxelf)"
> 
> in Makefile.am.  Could you please fix it?

This GENSCRIPTS not needed.
remove it.

> Thanks.
> 
> -- 
> H.J.

diff --git a/ld/ChangeLog b/ld/ChangeLog
index d7c841c..59e0600 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,12 @@
+2015-02-26  Yoshinori Sato <ysato@users.sourceforge.jp>
+
+	* Makefile.am (ALL_EMULATION_SOURCES): Sort order.
+	(eh8300elf_linux.c): remove GENSCRIPTS.
+	(eh8300helf_linux.c): Likewise.
+	(eh8300self_linux.c): Likewise.
+	(eh8300sxelf_linux.c): Likewise.
+	* Makefile.in: Regenerate.
+
 2015-02-24  Nick Clifton  <nickc@redhat.com>
 
 	* Makefile.am (ev850.c): Add dependency upon
diff --git a/ld/Makefile.am b/ld/Makefile.am
index 58daa41..7868ee8 100644
--- a/ld/Makefile.am
+++ b/ld/Makefile.am
@@ -284,9 +284,9 @@ ALL_EMULATION_SOURCES = \
 	egld960coff.c \
 	eh8300.c \
 	eh8300elf.c \
+	eh8300elf_linux.c \
 	eh8300h.c \
 	eh8300helf.c \
-	eh8300elf_linux.c \
 	eh8300hn.c \
 	eh8300hnelf.c \
 	eh8300helf_linux.c \
@@ -1311,7 +1311,6 @@ eh8300elf.c: $(srcdir)/emulparams/h8300elf.sh \
 
 eh8300elf_linux.c: $(srcdir)/emulparams/h8300elf_linux.sh \
   $(ELF_DEPS) $(srcdir)/scripttempl/elf.sc ${GEN_DEPENDS}
-	${GENSCRIPTS} h8300elf_linux "$(tdir_h8300elf)"
 
 eh8300h.c: $(srcdir)/emulparams/h8300h.sh \
   $(srcdir)/emultempl/generic.em $(srcdir)/scripttempl/h8300h.sc ${GEN_DEPENDS}
@@ -1323,7 +1322,6 @@ eh8300helf.c: $(srcdir)/emulparams/h8300helf.sh \
 eh8300helf_linux.c: $(srcdir)/emulparams/h8300helf_linux.sh \
   $(srcdir)/emulparams/h8300elf_linux.sh \
   $(ELF_DEPS) $(srcdir)/scripttempl/elf.sc ${GEN_DEPENDS}
-	${GENSCRIPTS} h8300helf_linux "$(tdir_h8300helf)"
 
 eh8300hn.c: $(srcdir)/emulparams/h8300hn.sh \
   $(srcdir)/emultempl/generic.em $(srcdir)/scripttempl/h8300hn.sc ${GEN_DEPENDS}
@@ -1342,7 +1340,6 @@ eh8300self.c: $(srcdir)/emulparams/h8300self.sh \
 eh8300self_linux.c: $(srcdir)/emulparams/h8300self_linux.sh \
   $(srcdir)/emulparams/h8300elf.sh \
   $(ELF_DEPS) $(srcdir)/scripttempl/elf.sc ${GEN_DEPENDS}
-	${GENSCRIPTS} h8300self_linux "$(tdir_h8300self)"
 
 eh8300sn.c: $(srcdir)/emulparams/h8300sn.sh \
   $(srcdir)/emultempl/generic.em $(srcdir)/scripttempl/h8300sn.sc ${GEN_DEPENDS}
@@ -1361,7 +1358,6 @@ eh8300sxelf.c: $(srcdir)/emulparams/h8300sxelf.sh \
 eh8300sxelf_linux.c: $(srcdir)/emulparams/h8300sxelf_linux.sh \
   $(srcdir)/emulparams/h8300elf.sh \
   $(ELF_DEPS) $(srcdir)/scripttempl/elf.sc ${GEN_DEPENDS}
-	${GENSCRIPTS} h8300sxelf_linux "$(tdir_h8300sxelf)"
 
 eh8300sxn.c: $(srcdir)/emulparams/h8300sxn.sh \
   $(srcdir)/emultempl/generic.em $(srcdir)/scripttempl/h8300sxn.sc ${GEN_DEPENDS}
diff --git a/ld/Makefile.in b/ld/Makefile.in
index 83dc7f1..2e1689c 100644
--- a/ld/Makefile.in
+++ b/ld/Makefile.in
@@ -614,9 +614,9 @@ ALL_EMULATION_SOURCES = \
 	eh8300elf_linux.c \
 	eh8300h.c \
 	eh8300helf.c \
-	eh8300helf_linux.c \
 	eh8300hn.c \
 	eh8300hnelf.c \
+	eh8300helf_linux.c \
 	eh8300s.c \
 	eh8300self.c \
 	eh8300self_linux.c \
@@ -624,9 +624,9 @@ ALL_EMULATION_SOURCES = \
 	eh8300snelf.c \
 	eh8300sx.c \
 	eh8300sxelf.c \
-	eh8300sxelf_linux.c \
 	eh8300sxn.c \
 	eh8300sxnelf.c \
+	eh8300sxelf_linux.c \
 	eh8500.c \
 	eh8500b.c \
 	eh8500c.c \
@@ -2800,9 +2800,10 @@ eh8300.c: $(srcdir)/emulparams/h8300.sh \
 
 eh8300elf.c: $(srcdir)/emulparams/h8300elf.sh \
   $(ELF_DEPS) $(srcdir)/scripttempl/elf.sc ${GEN_DEPENDS}
+
 eh8300elf_linux.c: $(srcdir)/emulparams/h8300elf_linux.sh \
   $(ELF_DEPS) $(srcdir)/scripttempl/elf.sc ${GEN_DEPENDS}
-	${GENSCRIPTS} h8300elf_linux "$(tdir_h8300elf)"
+
 eh8300h.c: $(srcdir)/emulparams/h8300h.sh \
   $(srcdir)/emultempl/generic.em $(srcdir)/scripttempl/h8300h.sc ${GEN_DEPENDS}
 
@@ -2813,7 +2814,7 @@ eh8300helf.c: $(srcdir)/emulparams/h8300helf.sh \
 eh8300helf_linux.c: $(srcdir)/emulparams/h8300helf_linux.sh \
   $(srcdir)/emulparams/h8300elf_linux.sh \
   $(ELF_DEPS) $(srcdir)/scripttempl/elf.sc ${GEN_DEPENDS}
-	${GENSCRIPTS} h8300helf_linux "$(tdir_h8300helf)"
+
 eh8300hn.c: $(srcdir)/emulparams/h8300hn.sh \
   $(srcdir)/emultempl/generic.em $(srcdir)/scripttempl/h8300hn.sc ${GEN_DEPENDS}
 
@@ -2831,7 +2832,7 @@ eh8300self.c: $(srcdir)/emulparams/h8300self.sh \
 eh8300self_linux.c: $(srcdir)/emulparams/h8300self_linux.sh \
   $(srcdir)/emulparams/h8300elf.sh \
   $(ELF_DEPS) $(srcdir)/scripttempl/elf.sc ${GEN_DEPENDS}
-	${GENSCRIPTS} h8300self_linux "$(tdir_h8300self)"
+
 eh8300sn.c: $(srcdir)/emulparams/h8300sn.sh \
   $(srcdir)/emultempl/generic.em $(srcdir)/scripttempl/h8300sn.sc ${GEN_DEPENDS}
 
@@ -2849,7 +2850,7 @@ eh8300sxelf.c: $(srcdir)/emulparams/h8300sxelf.sh \
 eh8300sxelf_linux.c: $(srcdir)/emulparams/h8300sxelf_linux.sh \
   $(srcdir)/emulparams/h8300elf.sh \
   $(ELF_DEPS) $(srcdir)/scripttempl/elf.sc ${GEN_DEPENDS}
-	${GENSCRIPTS} h8300sxelf_linux "$(tdir_h8300sxelf)"
+
 eh8300sxn.c: $(srcdir)/emulparams/h8300sxn.sh \
   $(srcdir)/emultempl/generic.em $(srcdir)/scripttempl/h8300sxn.sc ${GEN_DEPENDS}

-- 
Yoshinori Sato
<ysato@users.sourceforge.jp>

Follow-Ups:
- Re: Ping [PATCH, h8300] Add h8300-*-linux
  - From: Alan Modra

References:
- Ping [PATCH, h8300] Add h8300-*-linux
  - From: Yoshinori Sato
- Re: Ping [PATCH, h8300] Add h8300-*-linux
  - From: Nicholas Clifton
- Re: Ping [PATCH, h8300] Add h8300-*-linux
  - From: Yoshinori Sato
- Re: Ping [PATCH, h8300] Add h8300-*-linux
  - From: Nicholas Clifton
- Re: Ping [PATCH, h8300] Add h8300-*-linux
  - From: Yoshinori Sato
- Re: Ping [PATCH, h8300] Add h8300-*-linux
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]