This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [commited,PATCH] Set root.linker_def on _TLS_MODULE_BASE_
- From: Alan Modra <amodra at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Mon, 16 Feb 2015 12:21:17 +1030
- Subject: Re: [commited,PATCH] Set root.linker_def on _TLS_MODULE_BASE_
- Authentication-results: sourceware.org; auth=none
- References: <20150215175733 dot GA22557 at gmail dot com> <20150216011123 dot GC4274 at bubble dot grove dot modra dot org> <CAMe9rOp6f+nTLM7x2jaKBxut7TNXPgw8trYPphto3B1bnk964g at mail dot gmail dot com>
On Sun, Feb 15, 2015 at 05:21:33PM -0800, H.J. Lu wrote:
> On Sun, Feb 15, 2015 at 5:11 PM, Alan Modra <amodra@gmail.com> wrote:
> > On Sun, Feb 15, 2015 at 09:57:33AM -0800, H.J. Lu wrote:
> >> I checked in this patch to set root.linker_def on _TLS_MODULE_BASE_
> >>
> >> H.J.
> >> ---
> >> * elf32-i386.c (elf_i386_always_size_sections): Set root.linker_def
> >> on _TLS_MODULE_BASE_.
> >> * elf64-x86-64.c (elf_x86_64_always_size_sections): Likewise.
> >
> > Maybe use _bfd_elf_define_linkage_sym instead?
>
> Unfortunately, we can't since the logic is a little bit different:
[snip]
> Here we check
>
> if (tlsbase && tlsbase->type == STT_TLS)
You could call _bfd_elf_define_linkage_sym after this check, I think.
--
Alan Modra
Australia Development Lab, IBM