This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: RFC: [PATCH] Support -plugin-opt=disable-output for LLVM plugin
- From: Rafael EspÃndola <rafael dot espindola at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Wed, 11 Feb 2015 21:42:30 -0500
- Subject: Re: RFC: [PATCH] Support -plugin-opt=disable-output for LLVM plugin
- Authentication-results: sourceware.org; auth=none
- References: <20150211234140 dot GA18695 at intel dot com> <CAG3jReLoiE+scugTZXeJXeFVJpHuAOjErYcXCG5t55u5Q89A9g at mail dot gmail dot com> <CAMe9rOoX1FPMuOQXu+1xB_iyehGzaVxXG7siutHX-bCsvyEszA at mail dot gmail dot com> <CAG3jReLmhv20pTPqrkbggdxKYB11AaqVRoCsW_DXb4Tb6hW36w at mail dot gmail dot com> <CAMe9rOq0Gg5U94gPDvEv6VigQQTaouSHXQ_LtT-Y5AB8PB4iHQ at mail dot gmail dot com>
> You can use atexit. It is used elsewhere in llvm.
The plugin needs an early exit, not a way to schedule stuff to run at exit.
> 1. It expects gold:
>
> ld_version = subprocess.Popen(['ld', '--version'], stdout = subprocess.PIPE)
> if not 'GNU gold' in ld_version.stdout.read():
> return False
This should be fixed to be more general.
> 2. It expects elf32ppc support:
>
> emulations = fields[2].split()
> if 'elf32ppc' not in emulations or 'elf_x86_64' not in emulations:
> return False
>
> Even my gold doesn't have elf32ppc support.
This should be moved to a ppc specific subdirectory.
Cheers,
Rafael