Re: PATCH: PR ld/14272: Mark the plugin symbol undefined

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Thu, Feb 5, 2015 at 5:52 PM, Alan Modra <amodra@gmail.com> wrote:
> On Thu, Feb 05, 2015 at 05:06:38PM -0800, H.J. Lu wrote:
>> On Thu, Feb 5, 2015 at 4:59 PM, Alan Modra <amodra@gmail.com> wrote:
>> > On Wed, Feb 04, 2015 at 04:36:16AM -0800, H.J. Lu wrote:
>> >> On Wed, Feb 4, 2015 at 3:08 AM, Alan Modra <amodra@gmail.com> wrote:
>> >> > On Tue, Feb 03, 2015 at 09:06:47AM -0800, H.J. Lu wrote:
>> >> >>       PR ld/12365
>> >> >>       * ld-plugin/pr12365a.c: New file.
>> >> >>       * ld-plugin/pr12365b.c: Likewise.
>> >> >>       * ld-plugin/pr12365c.c: Likewise.
>> >> >
>> >> > The testcase fails when using gcc-5.  Also, gcc-5 objects don't seem
>> >> > exercise your _bfd_elf_fix_symbol_flags code.  I presume you need an
>> >> > older version of gcc, with lto bugs, to need those hacks.  Is that
>> >> > true?  Can you write a testcase that does exercise your
>> >> > _bfd_elf_fix_symbol_flags code?
>> >>
>> >> The -flto-partition default was changed.  I checked in this patch
>> >> to pass -flto-partition=none to the PR ld/12365 test.
>> >
>> > The test fails when using gcc-4.7.2 on powerpc64-linux.  Please fix it.
>>
>> Does it fail with gcc 4.8?  What is the error message?
>
> No error message.  The link succeeds.  Similarly with gcc-4.9 and

The test is very sensitive to LTO partition.  Also

#define ASMNAME(cname)  ASMNAME2 (__USER_LABEL_PREFIX__, cname)
#define ASMNAME2(prefix, cname) STRING (prefix) cname
#define STRING(x)    #x

typedef __SIZE_TYPE__ size_t;
extern void abort (void);
extern void *memcpy (void *, const void *, size_t)
  __asm (ASMNAME ("my_memcpy"));

doesn't work for all platforms.  I will keep digging.

> gcc-5 on powerpc64-linux.  Did you try your testcase on any
> architecture besides x64_64 and x86?
>

-- 
H.J.