This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [ARM][gas][2.25] Backport "vcmp/vcmpe should accept #0x0 as an operand."
- From: Tristan Gingold <gingold at adacore dot com>
- To: Matthew Wahab <matthew dot wahab at arm dot com>
- Cc: Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Wed, 28 Jan 2015 10:24:10 +0100
- Subject: Re: [ARM][gas][2.25] Backport "vcmp/vcmpe should accept #0x0 as an operand."
- Authentication-results: sourceware.org; auth=none
- References: <54B78B49 dot 2040209 at arm dot com> <CAJA7tRZzT7bAO2UM4fZ3+nXTPWZSAVAh70HFSG2mDFQiu2hBrA at mail dot gmail dot com> <54C7BFD0 dot 80505 at arm dot com>
> On 27 Jan 2015, at 17:41, Matthew Wahab <matthew.wahab@arm.com> wrote:
>
> On 27/01/15 15:09, Ramana Radhakrishnan wrote:
>> On Thu, Jan 15, 2015 at 9:41 AM, Matthew Wahab <matthew.wahab@arm.com> wrote:
>>> Hello,
>>>
>>> This is a backport to binutils-2.25 to fix an inadvertant behaviour change
>>> in GAS.
>>>
>>> The trunk change is here:
>>> https://sourceware.org/ml/binutils/2015-01/msg00077.html
>>> The commit log is here:
>>> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0900a05b4ce11a11fafbb691d94745bb65ac4980
>>>
>> It looks like you have an unintended hunk for changes to version.h in
>> bfd in this patch. That should not be applied as is to the tree. Ok by
>> me with that hunk removed.
> >
>> Please wait till Tristan CC'd ok's this being backported to 2.25.
>
> Attached an updated patch with the hunk removed. Also fixed some whitespace in the one of test files (spaces that should be tabs).
>
> Retested arm-none-linux-gnueabihf with check-gas with no failures.
Ok for the backport.
Tristan.
>
> Matthew
>
> gas/
> 2015-01-27 Matthew Wahab <matthew.wahab@arm.com>
>
> * config/tc-arm.c (parse_ifimm_zero): Accept #0x0 as a synonym for
> #0, restoring previous behaviour.
>
> testsuite/
> 2015-01-27 Matthew Wahab <matthew.wahab@arm.com>
>
> * gas/arm/ual-vcmp.s: Add vcmp, vcmpe with #0x0 operand.
> * gas/ual/vcmp.d: Update expected output.
> * gas/ual/vcmp-zero-bad.l: Likewise
>
>
> <vcmpimmzero_b225.patch>