Re: [RFC][PATCH] fix Read_symbols datarace

[Evgeniy Dushistov <dushistov at mail dot ru>]

On Wed, Nov 05, 2014 at 02:53:47PM -0800, Cary Coutant wrote:
> > After update to gcc 4.9.2, link of my project failed,
> > because of ld.gold crash.
> > I reproduce this problem:
> > https://sourceware.org/bugzilla/show_bug.cgi?id=17538
> > ...
> > Attached patch fix problem for me.
> > Comments?
> 
> Thanks for finding this! A couple of minor comments, but it looks good...
> 
> Please write a ChangeLog entry.
> 
> +      this_blocker_(NULL), extra_search_path_(), lock_(NULL),
> initialize_lock_(&lock_)
> 
> Line too long; please wrap.
> 
> +  Lock *lock_;
> 
> For C++ code, the "*" goes with the type: "Lock* lock_;".
> 

I fixed coding styles issues, and add changelog entry.
See attached patch.

> Do you have commit access?
> 
No, I saw the gold code the first time in my life,
so no, I have no commit access.


-- 
/Evgeniy

Attachment: patch
Description: Text document