This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][MIPS] Implement .module directive
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- Cc: "binutils\ at sourceware dot org" <binutils at sourceware dot org>, Rich Fuhler <Rich dot Fuhler at imgtec dot com>
- Date: Tue, 20 May 2014 23:07:47 +0100
- Subject: Re: [PATCH][MIPS] Implement .module directive
- Authentication-results: sourceware.org; auth=none
- References: <6D39441BF12EF246A7ABCE6654B02353538578 at LEMAIL01 dot le dot imgtec dot org> <87tx8kib4k dot fsf at talisman dot default> <6D39441BF12EF246A7ABCE6654B023535390A7 at LEMAIL01 dot le dot imgtec dot org>
Matthew Fortune <Matthew.Fortune@imgtec.com> writes:
>> > @@ -787,7 +787,7 @@ if { [istarget mips*-*-vxworks*] } {
>> > run_dump_test "relax-swap1-mips2"
>> > run_dump_test "relax-swap2"
>> > run_dump_test_arches "relax-swap3" [mips_arch_list_all]
>> > - run_list_test_arches "relax-bc1any" "-mips3d -relax-branch" \
>> > + run_list_test_arches "relax-bc1any" "-mips3d -64 -relax-branch" \
>> > [mips_arch_list_matching mips64 \
>> > !micromips]
>> > run_list_test_arches "relax-bposge" "-mdsp -relax-branch" \
>>
>> Not all targets compile in support for n32 and n64, so -mabi=o64 would
>> be better than -64.
>
> Will do. I had only run the assembler tests for this patch but on running
> the linker tests it showed a problem with .dc.a which is dependent on
> TC_ADDRESS_BYTES and that in turn is dependent on the GPR size. The
> mips_address_bytes function therefore has to finalise the options (because
> that is where the inferred GP register width is set up). This means that
> .dc.a is another pseudo that prevents further .module directives.
>
> Is that OK? (patch below to be applied along with the overall patch if
> approved)
Yeah, looks good to me, thanks.
Richard