This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Remove md_obj_{begin,end} from MIPS port


Back in the initial 1993 tc-mips.c commit, the calls to md_obj_begin and
md_obj_end were guarded by OBJ_ECOFF but became ECOFF_DEBUGGING a couple
of years later.  It looks like md_obj_begin was always empty and md_obj_end
now unconditionally applies.

Tested on various mips* targets and applied.

Thanks,
Richard


gas/
	* config/tc-mips.c (md_obj_begin): Delete.
	(md_obj_end): Fold into...
	(md_mips_end): ...here.  Move to end of file.

Index: gas/config/tc-mips.c
===================================================================
--- gas/config/tc-mips.c	2014-05-17 13:41:29.288092418 +0100
+++ gas/config/tc-mips.c	2014-05-17 13:41:37.425171035 +0100
@@ -1299,8 +1299,6 @@ static void s_ehword (int);
 static void s_cpadd (int);
 static void s_insn (int);
 static void s_nan (int);
-static void md_obj_begin (void);
-static void md_obj_end (void);
 static void s_mips_ent (int);
 static void s_mips_end (int);
 static void s_mips_frame (int);
@@ -3633,22 +3631,11 @@ md_begin (void)
     subseg_set (seg, subseg);
   }
 
-  if (! ECOFF_DEBUGGING)
-    md_obj_begin ();
-
   if (mips_fix_vr4120)
     init_vr4120_conflicts ();
 }
 
 void
-md_mips_end (void)
-{
-  mips_emit_delays ();
-  if (! ECOFF_DEBUGGING)
-    md_obj_end ();
-}
-
-void
 md_assemble (char *str)
 {
   struct mips_cl_insn insn;
@@ -17523,19 +17510,6 @@ mips_handle_align (fragS *fragp)
   fragp->fr_var = size;
 }
 
-static void
-md_obj_begin (void)
-{
-}
-
-static void
-md_obj_end (void)
-{
-  /* Check for premature end, nesting errors, etc.  */
-  if (cur_proc_ptr)
-    as_warn (_("missing .end at end of assembly"));
-}
-
 static long
 get_number (void)
 {
@@ -18375,3 +18349,11 @@ #define T(tag) {#tag, tag}
 
   return -1;
 }
+
+void
+md_mips_end (void)
+{
+  mips_emit_delays ();
+  if (cur_proc_ptr)
+    as_warn (_("missing .end at end of assembly"));
+}


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]