This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Fix alignment for the first section frag on xtensa
- From: Sterling Augustine <augustine dot sterling at gmail dot com>
- To: Max Filippov <jcmvbkbc at gmail dot com>
- Cc: binutils at sourceware dot org, David Weatherford <weath at cadence dot com>, Marc Gauthier <marc at cadence dot com>, "linux-xtensa at linux-xtensa dot org" <linux-xtensa at linux-xtensa dot org>
- Date: Tue, 22 Apr 2014 10:00:35 -0700
- Subject: Re: [PATCH] Fix alignment for the first section frag on xtensa
- Authentication-results: sourceware.org; auth=none
- References: <1398077682-22196-1-git-send-email-jcmvbkbc at gmail dot com> <CAGSvup85+Kqr56KqE6E3rw-jjepL==vezon1c9Q+P2NcdUX3wA at mail dot gmail dot com> <CAMo8BfJnTB0g0Vvk4+EmBvDLB_KNM11S-8GJ-p9+Ofxtgop0ng at mail dot gmail dot com>
On Tue, Apr 22, 2014 at 3:57 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> I'd be interested to see such test case.
The thing to remember is that the misaligned entry instruction is only
a symptom of the bug. The actual bug is that the section doesn't get
aligned.
So, keeping in mind that I never repro'd the original problem, my
guess is that I could get the label "bar" unaligned below, with
something along these lines:
foo.s
.text
.align 8
....//lots of code requiring relaxation
//some kind of padding that doesn't include actual text, but can be
adjusted by relaxation
bar.s
.global bar
//some code to ensure the current frag is closed.
bar:
.align 16 (should be greater than foo's alignment, and applies to the
entire section.)
I'd need to play with it a bit to get the details right.
The patch only applies to the frag where the alignment directive appears.
And, of course, I haven't written Xtensa code in years, so I may be
missing something.