This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Disable --long-plt test for arm-nacl targets.
- From: Roland McGrath <mcgrathr at google dot com>
- To: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Wed, 5 Mar 2014 10:06:41 -0800
- Subject: Re: [PATCH] Disable --long-plt test for arm-nacl targets.
- Authentication-results: sourceware.org; auth=none
- References: <CAB=4xhrvNmC-TW0ZV1mPLBRc6KGZ8nk_-aMZYgqaG5iOgeezWA at mail dot gmail dot com>
ping? Need trivial maintainer approval.
On Fri, Feb 28, 2014 at 9:59 AM, Roland McGrath <mcgrathr@google.com> wrote:
> The --long-plt switch is a no-op (and unnecessary) for arm-nacl targets.
> The test case does not apply.
>
> OK for trunk?
>
>
> Thanks,
> Roland
>
>
> ld/testsuite/
> 2014-02-28 Roland McGrath <mcgrathr@google.com>
>
> * ld-arm/arm-elf.exp (armelftests_common): Move long-plt case ...
> (armelftests_nonacl): ... here.
>
> --- a/ld/testsuite/ld-arm/arm-elf.exp
> +++ b/ld/testsuite/ld-arm/arm-elf.exp
> @@ -188,10 +188,6 @@ set armelftests_common {
> "" {exec-got-1b.s}
> {{readelf --relocs exec-got-1.d}}
> "exec-got-1"}
> - {"Long PLT entries in executables" "--long-plt -shared
> --section-start=.plt=0x200 --section-start=.got=0xf0000300" ""
> - "" {long-plt-format.s}
> - {{objdump "-d -j .plt" long-plt-format.d}}
> - "long-plt-format"}
> {"abs call" "-T arm.ld" "" "" {abs-call-1.s}
> {{objdump -d abs-call-1.d}}
> "abs-call-1"}
> @@ -460,6 +456,10 @@ set armelftests_nonacl {
> {objdump {-s -j.data -j.got} ifunc-17.gd}
> {readelf -r ifunc-17.rd}}
> "ifunc-17"}
> + {"Long PLT entries in executables" "--long-plt -shared
> --section-start=.plt=0x200 --section-start=.got=0xf0000300" ""
> + "" {long-plt-format.s}
> + {{objdump "-d -j .plt" long-plt-format.d}}
> + "long-plt-format"}
> }
>
> run_ld_link_tests $armelftests_common