This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[commit] [patch] Fix PowerPC targets minor memory leaks found by Coverity
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Binutils <binutils at sourceware dot org>
- Date: Tue, 4 Feb 2014 20:19:22 +0100
- Subject: [commit] [patch] Fix PowerPC targets minor memory leaks found by Coverity
- Authentication-results: sourceware.org; auth=none
- References: <20140124133831 dot GA27933 at host2 dot jankratochvil dot net> <20140127001215 dot GI5390 at bubble dot grove dot modra dot org>
On Mon, 27 Jan 2014 01:12:15 +0100, Alan Modra wrote:
> On Fri, Jan 24, 2014 at 02:38:31PM +0100, Jan Kratochvil wrote:
> > * elf32-ppc.c (ppc_elf_relax_section): Free FIXUPS in error_return
> > return path.
>
> This is not OK. There are paths to error_return before fixups have
> been allocated and after fixups have been freed. Please change the
> error_return free of fixups from a do { } while (); to a while () { }
> loop. OK with that change.
I see you have checked it in in the meantime as a part of:
commit 5446cbdf82892a800ed7eef563a795e75223ec52
Author: Alan Modra <amodra@gmail.com>
Date: Thu Jan 30 08:26:02 2014 +1030
ppc476 icache bug workaround
Checked in the other two parts as:
2915c55b41d00f12ed6bc54b4160e3367065c1c8
Thanks,
Jan