This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH/binutils-2_24-branch] libiberty: fix --enable-install-libiberty flag [PR 56780]
- From: Tristan Gingold <gingold at adacore dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: "binutils at sourceware dot org Development" <binutils at sourceware dot org>
- Date: Tue, 7 Jan 2014 09:16:06 +0100
- Subject: Re: [PATCH/binutils-2_24-branch] libiberty: fix --enable-install-libiberty flag [PR 56780]
- Authentication-results: sourceware.org; auth=none
- References: <1389034065-21952-1-git-send-email-vapier at gentoo dot org>
On 06 Jan 2014, at 19:47, Mike Frysinger <vapier@gentoo.org> wrote:
> I've committed this to upstream gcc and binutils master. OK for 2.24 branch ?
Yes, that's ok.
>
> Commit 199570 fixed the --disable-install-libiberty behavior, but it also
> added a bug where the enable path never works because the initial clear
> of target_header_dir wasn't deleted. So we end up initializing properly
> at the top only to reset it at the end all the time.
>
> git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@206367 138bc75d-0d04-0410-961f-82ee72b054a4
> ---
> libiberty/ChangeLog | 6 ++++++
> libiberty/configure | 1 -
> libiberty/configure.ac | 1 -
> 3 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/libiberty/ChangeLog b/libiberty/ChangeLog
> index 9a5ace1..ad0b1bd 100644
> --- a/libiberty/ChangeLog
> +++ b/libiberty/ChangeLog
> @@ -1,3 +1,9 @@
> +2014-01-06 Mike Frysinger <vapier@gentoo.org>
> +
> + PR other/56780
> + * configure.ac: Delete target_header_dir assignment.
> + * configure: Regenerated.
> +
> 2014-01-06 Gary Benson <gbenson@redhat.com>
>
> * cp-demangle.c (struct d_print_info): New fields
> diff --git a/libiberty/configure b/libiberty/configure
> index 8ea54da..7bde9b3 100755
> --- a/libiberty/configure
> +++ b/libiberty/configure
> @@ -5510,7 +5510,6 @@ fi
>
> setobjs=
> CHECK=
> -target_header_dir=
> if test -n "${with_target_subdir}"; then
>
> # We are being configured as a target library. AC_REPLACE_FUNCS
> diff --git a/libiberty/configure.ac b/libiberty/configure.ac
> index 4ad88a9..d6180bc 100644
> --- a/libiberty/configure.ac
> +++ b/libiberty/configure.ac
> @@ -411,7 +411,6 @@ fi
>
> setobjs=
> CHECK=
> -target_header_dir=
> if test -n "${with_target_subdir}"; then
>
> # We are being configured as a target library. AC_REPLACE_FUNCS
> --
> 1.8.4.3
>