This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 1/2] bfd/elfnn-aarch64.c: Fix miscalculation of GOTPLT offset for ifunc syms.
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Will Newton <will dot newton at linaro dot org>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, Patch Tracking <patches at linaro dot org>
- Date: Tue, 26 Nov 2013 10:29:29 +0000
- Subject: Re: [PATCH 1/2] bfd/elfnn-aarch64.c: Fix miscalculation of GOTPLT offset for ifunc syms.
- Authentication-results: sourceware.org; auth=none
- References: <529461A9 dot 4060909 at linaro dot org>
On 26 November 2013 08:54, Will Newton <will.newton@linaro.org> wrote:
>
> The .got.plt header size was not being correctly taken into account
> when calculating the offset for relocations against ifunc symbols.
>
> bfd/ChangeLog:
>
> 2013-11-25 Will Newton <will.newton@linaro.org>
>
> * elfnn-aarch64.c (elfNN_aarch64_final_link_relocate): Ensure
> PLT_INDEX is calculated using correct header size.
>
> ld/testsuite/ChangeLog:
>
> 2013-11-25 Will Newton <will.newton@linaro.org>
>
> * ld-aarch64/aarch64-elf.exp: Add ifunc-21 test.
> * ld-aarch64/ifunc-21.d: New file.
> * ld-aarch64/ifunc-21.s: Likewise.
This looks OK to me.
/Marcus